U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mtd: remove stale comment in mtd_oob_ops structure
@ 2018-07-14 12:37 Miquel Raynal
  2018-07-26 19:54 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Miquel Raynal @ 2018-07-14 12:37 UTC (permalink / raw)
  To: u-boot

A comment in the kernel doc of the mtd_oob_ops structure tells that it
is not possible to write more than one page with OOB. This was
probably true at some time in the past but today it is entirely wrong.

As one can see for instance in the nand_do_write_ops() helper available
in the NAND core, this implementation called by mtd->_write_oob()
simply loops over the pages until everything has been written.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 include/linux/mtd/mtd.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 0c41140465..823e535b82 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -75,10 +75,6 @@ struct mtd_erase_region_info {
  *		mode = MTD_OPS_PLACE_OOB or MTD_OPS_RAW)
  * @datbuf:	data buffer - if NULL only oob data are read/written
  * @oobbuf:	oob data buffer
- *
- * Note, it is allowed to read more than one OOB area at one go, but not write.
- * The interface assumes that the OOB write requests program only one page's
- * OOB area.
  */
 struct mtd_oob_ops {
 	unsigned int	mode;
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] mtd: remove stale comment in mtd_oob_ops structure
  2018-07-14 12:37 [U-Boot] [PATCH] mtd: remove stale comment in mtd_oob_ops structure Miquel Raynal
@ 2018-07-26 19:54 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-07-26 19:54 UTC (permalink / raw)
  To: u-boot

On Sat, Jul 14, 2018 at 02:37:19PM +0200, Miquel Raynal wrote:

> A comment in the kernel doc of the mtd_oob_ops structure tells that it
> is not possible to write more than one page with OOB. This was
> probably true at some time in the past but today it is entirely wrong.
> 
> As one can see for instance in the nand_do_write_ops() helper available
> in the NAND core, this implementation called by mtd->_write_oob()
> simply loops over the pages until everything has been written.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180726/9b82745a/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-26 19:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-14 12:37 [U-Boot] [PATCH] mtd: remove stale comment in mtd_oob_ops structure Miquel Raynal
2018-07-26 19:54 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox