[U-Boot] Keystone 2 sram scratch address?

[U-Boot] Keystone 2 sram scratch address?

[Tom Rini]

Hey folks,

So as part of Simon's patch[1] to move CONFIG_SPL_TEXT_BASE to Kconfig
I've run into a problem on Keystone 2 platforms, specifically the HS
variants.  What keystone does is define the SRAM scratch address
relative to the end of our regular SRAM usage for SPL.  This is I think
in part due to the large variation in the SRAM size on these parts
contain and a desire to be able to more easily support the larger sizes.
This is fine on the non-HS parts where we enable and build SPL so can
play these games.  But on the HS parts (or at least k2l_hs_evm
k2e_hs_evm k2hk_hs_evm k2g_hs_evm) we don't use SPL, so once moving
CONFIG_SPL_TEXT_BASE to Kconfig we don't have it defined and a few
places fall apart.  Can we find some constant we could use for
CONFIG_SYS_INIT_SP_ADDR and then for the EEPROM copy we make on K2G?
Thanks!


[1]: https://patchwork.ozlabs.org/patch/976918/
-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181007/652a0fa0/attachment.sig>

[U-Boot] Keystone 2 sram scratch address?

[Lokesh Vutla]

Hi Tom,

On 10/7/2018 7:29 PM, Tom Rini wrote:
> Hey folks,
> 
> So as part of Simon's patch[1] to move CONFIG_SPL_TEXT_BASE to Kconfig
> I've run into a problem on Keystone 2 platforms, specifically the HS
> variants.  What keystone does is define the SRAM scratch address
> relative to the end of our regular SRAM usage for SPL.  This is I think
> in part due to the large variation in the SRAM size on these parts
> contain and a desire to be able to more easily support the larger sizes.
> This is fine on the non-HS parts where we enable and build SPL so can
> play these games.  But on the HS parts (or at least k2l_hs_evm
> k2e_hs_evm k2hk_hs_evm k2g_hs_evm) we don't use SPL, so once moving
> CONFIG_SPL_TEXT_BASE to Kconfig we don't have it defined and a few
> places fall apart.  Can we find some constant we could use for
> CONFIG_SYS_INIT_SP_ADDR and then for the EEPROM copy we make on K2G?

I guess we can use the same constant as SPL_TEXT_BASE for all the platforms?

diff --git a/include/configs/k2hk_evm.h b/include/configs/k2hk_evm.h
index 0b909a1bf6..0ffbc464cc 100644
--- a/include/configs/k2hk_evm.h
+++ b/include/configs/k2hk_evm.h
@@ -40,8 +40,7 @@

 #include <configs/ti_armv7_keystone2.h>

-/* SPL SPI Loader Configuration */
-#define CONFIG_SPL_TEXT_BASE		0x0c200000
+#define CONFIG_SYS_INIT_SP_ADDR		0x0c200000

 #define SPI_MTD_PARTS KEYSTONE_SPI0_MTD_PARTS


Thanks and regards,
Lokesh

[U-Boot] Keystone 2 sram scratch address?

[Tom Rini]

On Mon, Oct 08, 2018 at 10:47:06AM +0530, Lokesh Vutla wrote:
> Hi Tom,
> 
> On 10/7/2018 7:29 PM, Tom Rini wrote:
> > Hey folks,
> > 
> > So as part of Simon's patch[1] to move CONFIG_SPL_TEXT_BASE to Kconfig
> > I've run into a problem on Keystone 2 platforms, specifically the HS
> > variants.  What keystone does is define the SRAM scratch address
> > relative to the end of our regular SRAM usage for SPL.  This is I think
> > in part due to the large variation in the SRAM size on these parts
> > contain and a desire to be able to more easily support the larger sizes.
> > This is fine on the non-HS parts where we enable and build SPL so can
> > play these games.  But on the HS parts (or at least k2l_hs_evm
> > k2e_hs_evm k2hk_hs_evm k2g_hs_evm) we don't use SPL, so once moving
> > CONFIG_SPL_TEXT_BASE to Kconfig we don't have it defined and a few
> > places fall apart.  Can we find some constant we could use for
> > CONFIG_SYS_INIT_SP_ADDR and then for the EEPROM copy we make on K2G?
> 
> I guess we can use the same constant as SPL_TEXT_BASE for all the platforms?
> 
> diff --git a/include/configs/k2hk_evm.h b/include/configs/k2hk_evm.h
> index 0b909a1bf6..0ffbc464cc 100644
> --- a/include/configs/k2hk_evm.h
> +++ b/include/configs/k2hk_evm.h
> @@ -40,8 +40,7 @@
> 
>  #include <configs/ti_armv7_keystone2.h>
> 
> -/* SPL SPI Loader Configuration */
> -#define CONFIG_SPL_TEXT_BASE		0x0c200000
> +#define CONFIG_SYS_INIT_SP_ADDR		0x0c200000
> 
>  #define SPI_MTD_PARTS KEYSTONE_SPI0_MTD_PARTS

If there's not a constant we can use for all K2 platforms then, OK, I'll
work-something up based on that idea.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181008/1c63b043/attachment.sig>