From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/7] dm: serial: Add ->getconfig() callback
Date: Mon, 3 Dec 2018 18:18:31 +0200 [thread overview]
Message-ID: <20181203161831.GO10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181127160254.GY10650@smile.fi.intel.com>
On Tue, Nov 27, 2018 at 06:02:54PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 26, 2018 at 06:02:28PM -0700, Simon Glass wrote:
> > On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > In some cases it would be good to know the settings, such as parity,
> > > of current serial console. One example might be an ACPI SPCR table
> > > to generate using these parameters.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/serial/sandbox.c | 13 +++++++++++++
> > > drivers/serial/serial-uclass.c | 16 ++++++++++++++++
> > > include/common.h | 1 +
> > > include/serial.h | 26 +++++++++++++++++++++++---
> > > test/dm/serial.c | 7 +++++++
> > > 5 files changed, 60 insertions(+), 3 deletions(-)
> > >
> >
> > My only concern is that serial_get_config() should have a device parameter.
>
> It's obviously out of scope of this series.
>
> The rest of similar functions are operate on top of current console device and
> do not have such parameter, while being DM-based functions.
>
> I would gladly rebase my series on top any work which is done regard above request.
> For now, I don't see such possibility.
So, time passed w/o a single action to this.
Is the feature undesirable? I would easily stop doing it, it consumes valuable time.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-12-03 16:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 21:52 [U-Boot] [PATCH v3 0/7] ACPI: Generate SPCR table Andy Shevchenko
2018-11-20 21:52 ` [U-Boot] [PATCH v3 1/7] dm: serial: Add ->getconfig() callback Andy Shevchenko
2018-11-27 1:02 ` Simon Glass
2018-11-27 16:02 ` Andy Shevchenko
2018-12-03 16:18 ` Andy Shevchenko [this message]
2018-12-05 12:55 ` Simon Glass
2018-12-05 14:01 ` Andy Shevchenko
2018-12-05 15:58 ` Simon Glass
2018-12-05 23:11 ` sjg at google.com
2018-11-20 21:52 ` [U-Boot] [PATCH v3 2/7] dm: serial: Introduce ->getinfo() callback Andy Shevchenko
2018-12-05 12:55 ` Simon Glass
2018-12-05 23:11 ` sjg at google.com
2018-11-20 21:52 ` [U-Boot] [PATCH v3 3/7] serial: ns16550: Group reg_* members of ns16550_platdata Andy Shevchenko
2018-12-05 12:55 ` Simon Glass
2018-12-05 23:11 ` sjg at google.com
2018-11-20 21:52 ` [U-Boot] [PATCH v3 4/7] serial: ns16550: Read reg-io-width from device tree Andy Shevchenko
2018-12-05 12:55 ` Simon Glass
2018-12-05 23:11 ` sjg at google.com
2018-11-20 21:52 ` [U-Boot] [PATCH v3 5/7] serial: ns16550: Provide ->getinfo() implementation Andy Shevchenko
2018-12-05 12:55 ` Simon Glass
2018-12-05 23:11 ` sjg at google.com
2018-11-20 21:52 ` [U-Boot] [PATCH v3 6/7] x86: acpi: Add SPCR table description Andy Shevchenko
2018-12-05 23:11 ` sjg at google.com
2018-11-20 21:52 ` [U-Boot] [PATCH v3 7/7] x86: acpi: Generate SPCR table Andy Shevchenko
2018-12-05 12:55 ` Simon Glass
2018-12-05 23:11 ` sjg at google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203161831.GO10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox