* [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug
@ 2018-12-06 9:50 Sekhar Nori
2018-12-06 10:54 ` Lokesh Vutla
2018-12-06 21:42 ` Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Sekhar Nori @ 2018-12-06 9:50 UTC (permalink / raw)
To: u-boot
We usually deal with hexadecimal addresses and sizes in
device-tree. Its much easier if debug logs print hexadecimal
values too.
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
common/fdt_support.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 3440e42a257b..42583e3ed8c8 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -1025,7 +1025,7 @@ static u64 of_bus_default_map(fdt32_t *addr, const fdt32_t *range,
s = fdt_read_number(range + na + pna, ns);
da = fdt_read_number(addr, na);
- debug("OF: default map, cp=%llu, s=%llu, da=%llu\n", cp, s, da);
+ debug("OF: default map, cp=%llx, s=%llx, da=%llx\n", cp, s, da);
if (da < cp || da >= (cp + s))
return OF_BAD_ADDR;
@@ -1080,7 +1080,7 @@ static u64 of_bus_isa_map(fdt32_t *addr, const fdt32_t *range,
s = fdt_read_number(range + na + pna, ns);
da = fdt_read_number(addr + 1, na - 1);
- debug("OF: ISA map, cp=%llu, s=%llu, da=%llu\n", cp, s, da);
+ debug("OF: ISA map, cp=%llx, s=%llx, da=%llx\n", cp, s, da);
if (da < cp || da >= (cp + s))
return OF_BAD_ADDR;
--
2.16.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug
2018-12-06 9:50 [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug Sekhar Nori
@ 2018-12-06 10:54 ` Lokesh Vutla
2018-12-06 21:42 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Lokesh Vutla @ 2018-12-06 10:54 UTC (permalink / raw)
To: u-boot
On 06/12/18 3:20 PM, Sekhar Nori wrote:
> We usually deal with hexadecimal addresses and sizes in
> device-tree. Its much easier if debug logs print hexadecimal
> values too.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> common/fdt_support.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index 3440e42a257b..42583e3ed8c8 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -1025,7 +1025,7 @@ static u64 of_bus_default_map(fdt32_t *addr, const fdt32_t *range,
> s = fdt_read_number(range + na + pna, ns);
> da = fdt_read_number(addr, na);
>
> - debug("OF: default map, cp=%llu, s=%llu, da=%llu\n", cp, s, da);
> + debug("OF: default map, cp=%llx, s=%llx, da=%llx\n", cp, s, da);
>
> if (da < cp || da >= (cp + s))
> return OF_BAD_ADDR;
> @@ -1080,7 +1080,7 @@ static u64 of_bus_isa_map(fdt32_t *addr, const fdt32_t *range,
> s = fdt_read_number(range + na + pna, ns);
> da = fdt_read_number(addr + 1, na - 1);
>
> - debug("OF: ISA map, cp=%llu, s=%llu, da=%llu\n", cp, s, da);
> + debug("OF: ISA map, cp=%llx, s=%llx, da=%llx\n", cp, s, da);
>
> if (da < cp || da >= (cp + s))
> return OF_BAD_ADDR;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug
2018-12-06 9:50 [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug Sekhar Nori
2018-12-06 10:54 ` Lokesh Vutla
@ 2018-12-06 21:42 ` Tom Rini
2018-12-28 20:47 ` sjg at google.com
1 sibling, 1 reply; 4+ messages in thread
From: Tom Rini @ 2018-12-06 21:42 UTC (permalink / raw)
To: u-boot
On Thu, Dec 06, 2018 at 03:20:47PM +0530, Sekhar Nori wrote:
> We usually deal with hexadecimal addresses and sizes in
> device-tree. Its much easier if debug logs print hexadecimal
> values too.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181206/ffce804b/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug
2018-12-06 21:42 ` Tom Rini
@ 2018-12-28 20:47 ` sjg at google.com
0 siblings, 0 replies; 4+ messages in thread
From: sjg at google.com @ 2018-12-28 20:47 UTC (permalink / raw)
To: u-boot
On Thu, Dec 06, 2018 at 03:20:47PM +0530, Sekhar Nori wrote:
> We usually deal with hexadecimal addresses and sizes in
> device-tree. Its much easier if debug logs print hexadecimal
> values too.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
Applied to u-boot-dm/master, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-28 20:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-06 9:50 [U-Boot] [PATCH v2] common: fdt_support: print hexadecimal numbers in debug Sekhar Nori
2018-12-06 10:54 ` Lokesh Vutla
2018-12-06 21:42 ` Tom Rini
2018-12-28 20:47 ` sjg at google.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox