U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] buildman and "echo" output?
@ 2018-12-13 16:01 Tom Rini
  2018-12-14  7:21 ` Chris Packham
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Rini @ 2018-12-13 16:01 UTC (permalink / raw)
  To: u-boot

Hey Simon,

How hard would it be to have buildman notice and print out the echo'd
warnings we have in the toplevel Makefile?  By which I mean if you use
buildman to build omap3_beagle you see just the DT warnings but if you
run make by hand you also get:
==================== WARNING ======================
This board does not use CONFIG_DM_MMC. Please update
the board to use CONFIG_DM_MMC before the v2019.04 release.
Failure to update by the deadline may result in board removal.
See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release.
Failure to update by the deadline may result in board removal.
See doc/driver-model/MIGRATION.txt for more info.
====================================================

and as we want to get these things migrated we should make sure buildman
shows them I think.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181213/52c74a46/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] buildman and "echo" output?
  2018-12-13 16:01 [U-Boot] buildman and "echo" output? Tom Rini
@ 2018-12-14  7:21 ` Chris Packham
  2018-12-14 12:23   ` Tom Rini
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Packham @ 2018-12-14  7:21 UTC (permalink / raw)
  To: u-boot

Hi Tom, Simon,

On Fri, Dec 14, 2018 at 5:01 AM Tom Rini <trini@konsulko.com> wrote:
>
> Hey Simon,
>
> How hard would it be to have buildman notice and print out the echo'd
> warnings we have in the toplevel Makefile?  By which I mean if you use
> buildman to build omap3_beagle you see just the DT warnings but if you
> run make by hand you also get:
> ==================== WARNING ======================
> This board does not use CONFIG_DM_MMC. Please update
> the board to use CONFIG_DM_MMC before the v2019.04 release.
> Failure to update by the deadline may result in board removal.
> See doc/driver-model/MIGRATION.txt for more info.
> ====================================================
> ===================== WARNING ======================
> This board does not use CONFIG_DM_USB. Please update
> the board to use CONFIG_DM_USB before the v2019.07 release.
> Failure to update by the deadline may result in board removal.
> See doc/driver-model/MIGRATION.txt for more info.
> ====================================================
>
> and as we want to get these things migrated we should make sure buildman
> shows them I think.  Thanks!
>

If these appear on stderr buildman seems to output them. I could turn
the following into a proper patch if you want.

> --diff --git a/Makefile b/Makefile
index 5683714947f2..3666396a034c 100644
--- a/Makefile
+++ b/Makefile
@@ -913,47 +913,47 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \

 all:           $(ALL-y) cfg
 ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
-       @echo "===================== WARNING ======================"
-       @echo "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
-       @echo "(possibly in a subsequent patch in your series)"
-       @echo "before sending patches to the mailing list."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board uses CONFIG_DM_I2C_COMPAT. Please remove"  >&2
+       @echo "(possibly in a subsequent patch in your series)"      >&2
+       @echo "before sending patches to the mailing list."          >&2
+       @echo "====================================================" >&2
 endif
 ifeq ($(CONFIG_MMC),y)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
-       @echo "===================== WARNING ======================"
-       @echo "This board does not use CONFIG_DM_MMC. Please update"
-       @echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
-       @echo "Failure to update by the deadline may result in board removal."
-       @echo "See doc/driver-model/MIGRATION.txt for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board does not use CONFIG_DM_MMC. Please update" >&2
+       @echo "the board to use CONFIG_DM_MMC before the v2019.04 release." >&2
+       @echo "Failure to update by the deadline may result in board
removal." >&2
+       @echo "See doc/driver-model/MIGRATION.txt for more info."    >&2
+       @echo "====================================================" >&2
 endif
 endif
 ifeq ($(CONFIG_USB),y)
 ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
-       @echo "===================== WARNING ======================"
-       @echo "This board does not use CONFIG_DM_USB. Please update"
-       @echo "the board to use CONFIG_DM_USB before the v2019.07 release."
-       @echo "Failure to update by the deadline may result in board removal."
-       @echo "See doc/driver-model/MIGRATION.txt for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board does not use CONFIG_DM_USB. Please update" >&2
+       @echo "the board to use CONFIG_DM_USB before the v2019.07 release." >&2
+       @echo "Failure to update by the deadline may result in board
removal." >&2
+       @echo "See doc/driver-model/MIGRATION.txt for more info."    >&2
+       @echo "====================================================" >&2
 endif
 endif
 ifeq ($(CONFIG_LIBATA)$(CONFIG_DM_SCSI)$(CONFIG_MVSATA_IDE),y)
-       @echo "===================== WARNING ======================"
-       @echo "This board does not use CONFIG_DM_SCSI. Please update"
-       @echo "the storage controller to use CONFIG_DM_SCSI before the
v2019.07 release."
-       @echo "Failure to update by the deadline may result in board removal."
-       @echo "See doc/driver-model/MIGRATION.txt for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board does not use CONFIG_DM_SCSI. Please update" >&2
+       @echo "the storage controller to use CONFIG_DM_SCSI before the
v2019.07 release." >&2
+       @echo "Failure to update by the deadline may result in board
removal." >&2
+       @echo "See doc/driver-model/MIGRATION.txt for more info."    >&2
+       @echo "====================================================" >&2
 endif
 ifeq ($(CONFIG_OF_EMBED),y)
-       @echo "===================== WARNING ======================"
-       @echo "CONFIG_OF_EMBED is enabled. This option should only"
-       @echo "be used for debugging purposes. Please use"
-       @echo "CONFIG_OF_SEPARATE for boards in mainline."
-       @echo "See doc/README.fdt-control for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "CONFIG_OF_EMBED is enabled. This option should only"  >&2
+       @echo "be used for debugging purposes. Please use"           >&2
+       @echo "CONFIG_OF_SEPARATE for boards in mainline."           >&2
+       @echo "See doc/README.fdt-control for more info."            >&2
+       @echo "====================================================" >&2
 endif
        @# Check that this build does not use CONFIG options that we do not
        @# know about unless they are in Kconfig. All the existing CONFIG

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] buildman and "echo" output?
  2018-12-14  7:21 ` Chris Packham
@ 2018-12-14 12:23   ` Tom Rini
  2018-12-14 17:23     ` Simon Glass
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Rini @ 2018-12-14 12:23 UTC (permalink / raw)
  To: u-boot

On Fri, Dec 14, 2018 at 08:21:36PM +1300, Chris Packham wrote:
> Hi Tom, Simon,
> 
> On Fri, Dec 14, 2018 at 5:01 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > Hey Simon,
> >
> > How hard would it be to have buildman notice and print out the echo'd
> > warnings we have in the toplevel Makefile?  By which I mean if you use
> > buildman to build omap3_beagle you see just the DT warnings but if you
> > run make by hand you also get:
> > ==================== WARNING ======================
> > This board does not use CONFIG_DM_MMC. Please update
> > the board to use CONFIG_DM_MMC before the v2019.04 release.
> > Failure to update by the deadline may result in board removal.
> > See doc/driver-model/MIGRATION.txt for more info.
> > ====================================================
> > ===================== WARNING ======================
> > This board does not use CONFIG_DM_USB. Please update
> > the board to use CONFIG_DM_USB before the v2019.07 release.
> > Failure to update by the deadline may result in board removal.
> > See doc/driver-model/MIGRATION.txt for more info.
> > ====================================================
> >
> > and as we want to get these things migrated we should make sure buildman
> > shows them I think.  Thanks!
> >
> 
> If these appear on stderr buildman seems to output them. I could turn
> the following into a proper patch if you want.

Seems like the most reasonable way to fix this, yes please, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/2ae0756f/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] buildman and "echo" output?
  2018-12-14 12:23   ` Tom Rini
@ 2018-12-14 17:23     ` Simon Glass
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2018-12-14 17:23 UTC (permalink / raw)
  To: u-boot

Hi,

On Fri, 14 Dec 2018 at 05:23, Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Dec 14, 2018 at 08:21:36PM +1300, Chris Packham wrote:
> > Hi Tom, Simon,
> >
> > On Fri, Dec 14, 2018 at 5:01 AM Tom Rini <trini@konsulko.com> wrote:
> > >
> > > Hey Simon,
> > >
> > > How hard would it be to have buildman notice and print out the echo'd
> > > warnings we have in the toplevel Makefile?  By which I mean if you use
> > > buildman to build omap3_beagle you see just the DT warnings but if you
> > > run make by hand you also get:
> > > ==================== WARNING ======================
> > > This board does not use CONFIG_DM_MMC. Please update
> > > the board to use CONFIG_DM_MMC before the v2019.04 release.
> > > Failure to update by the deadline may result in board removal.
> > > See doc/driver-model/MIGRATION.txt for more info.
> > > ====================================================
> > > ===================== WARNING ======================
> > > This board does not use CONFIG_DM_USB. Please update
> > > the board to use CONFIG_DM_USB before the v2019.07 release.
> > > Failure to update by the deadline may result in board removal.
> > > See doc/driver-model/MIGRATION.txt for more info.
> > > ====================================================
> > >
> > > and as we want to get these things migrated we should make sure buildman
> > > shows them I think.  Thanks!
> > >
> >
> > If these appear on stderr buildman seems to output them. I could turn
> > the following into a proper patch if you want.
>
> Seems like the most reasonable way to fix this, yes please, thanks!

Yes that makes sense, and these will also show up as warnings in buildman.

Regards,
Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-12-14 17:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-13 16:01 [U-Boot] buildman and "echo" output? Tom Rini
2018-12-14  7:21 ` Chris Packham
2018-12-14 12:23   ` Tom Rini
2018-12-14 17:23     ` Simon Glass

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox