From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/11] exynos: Convert to use CONFIG_BLK
Date: Mon, 17 Dec 2018 08:48:48 +0100 [thread overview]
Message-ID: <20181217084848.232c9f29@jawa> (raw)
In-Reply-To: <20181217023638.39803-5-sjg@chromium.org>
On Sun, 16 Dec 2018 19:36:31 -0700
Simon Glass <sjg@chromium.org> wrote:
> Move all exynos boards over to use CONFIG_BLK.
>
> This converts s5p_goni also, but adding dummy functions for pinmux and
> peripheral ID. This will not function correctly, but gives the
> maintainer more time to convert the board if desired.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Update to convert s5p_goni also
>
> arch/arm/mach-exynos/Kconfig | 7 +++++++
> arch/arm/mach-s5pc1xx/Kconfig | 2 ++
> arch/arm/mach-s5pc1xx/Makefile | 1 +
> arch/arm/mach-s5pc1xx/pinmux.c | 20 ++++++++++++++++++++
> 4 files changed, 30 insertions(+)
> create mode 100644 arch/arm/mach-s5pc1xx/pinmux.c
>
> diff --git a/arch/arm/mach-exynos/Kconfig
> b/arch/arm/mach-exynos/Kconfig index ed04369cfae..38077703621 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -8,6 +8,8 @@ config ARCH_EXYNOS4
> bool "Exynos4 SoC family"
> select BOARD_EARLY_INIT_F
> select CPU_V7A
> + select BLK
> + select DM_MMC
> help
> Samsung Exynos4 SoC family are based on ARM Cortex-A9 CPU.
> There are multiple SoCs in this family including Exynos4210,
> Exynos4412, @@ -24,6 +26,9 @@ config ARCH_EXYNOS5
> imply USB_ETHER_ASIX
> imply USB_ETHER_RTL8152
> imply USB_ETHER_SMSC95XX
> + select BLK
> + select DM_MMC
> +
> help
> Samsung Exynos5 SoC family are based on ARM Cortex-A15 CPU
> (and Cortex-A7 CPU in big.LITTLE configuration). There are multiple
> SoCs @@ -33,6 +38,8 @@ config ARCH_EXYNOS7
> bool "Exynos7 SoC family"
> select ARM64
> select BOARD_EARLY_INIT_F
> + select BLK
> + select DM_MMC
> help
> Samsung Exynos7 SoC family are based on ARM Cortex-A57 CPU
> or Cortex-A53 CPU (and some in a big.LITTLE configuration). There are
> diff --git a/arch/arm/mach-s5pc1xx/Kconfig
> b/arch/arm/mach-s5pc1xx/Kconfig index 04acdaad79c..8cffced5512 100644
> --- a/arch/arm/mach-s5pc1xx/Kconfig
> +++ b/arch/arm/mach-s5pc1xx/Kconfig
> @@ -7,6 +7,8 @@ choice
> config TARGET_S5P_GONI
> bool "S5P Goni board"
> select OF_CONTROL
> + select BLK
> + select DM_MMC
>
> config TARGET_SMDKC100
> bool "Support smdkc100 board"
> diff --git a/arch/arm/mach-s5pc1xx/Makefile
> b/arch/arm/mach-s5pc1xx/Makefile index a4be3fcbdae..ab804604d54 100644
> --- a/arch/arm/mach-s5pc1xx/Makefile
> +++ b/arch/arm/mach-s5pc1xx/Makefile
> @@ -10,3 +10,4 @@ obj-y = cache.o
> obj-y += reset.o
>
> obj-y += clock.o
> +obj-y += pinmux.o
> diff --git a/arch/arm/mach-s5pc1xx/pinmux.c
> b/arch/arm/mach-s5pc1xx/pinmux.c new file mode 100644
> index 00000000000..511e57a28df
> --- /dev/null
> +++ b/arch/arm/mach-s5pc1xx/pinmux.c
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Dummy functions to keep s3p_goni building (although it won't work)
^^^^ s5p_goni
> + *
> + * Copyright 2018 Google LLC
> + * Written by Simon Glass <sjg@chromium.org>
> + */
> +
> +#include <common.h>
> +#include <asm/arch/pinmux.h>
> +
> +int exynos_pinmux_config(int peripheral, int flags)
> +{
> + return 0;
> +}
> +
> +int pinmux_decode_periph_id(const void *blob, int node)
> +{
> + return 0;
> +}
Despite the above comment, rest seems Ok.
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181217/96455b7f/attachment.sig>
next prev parent reply other threads:[~2018-12-17 7:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181217023702epcas3p1209a5ebb75a242bf9fa217a39bc13fb8@epcas3p1.samsung.com>
2018-12-17 2:36 ` [U-Boot] [PATCH v2 00/11] samsung: Tidy up sound, DM_MMC drop dead code Simon Glass
2018-12-17 2:36 ` [U-Boot] [PATCH v2 01/11] odroid: Resync defconfigs Simon Glass
2018-12-17 7:46 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 02/11] Convert CONFIG_BOARD_TYPES to Kconfig Simon Glass
2018-12-17 7:46 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 03/11] exynos: Drop duplicate 'model' line Simon Glass
2018-12-17 7:47 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 04/11] exynos: Convert to use CONFIG_BLK Simon Glass
2018-12-17 7:48 ` Lukasz Majewski [this message]
2018-12-17 2:36 ` [U-Boot] [PATCH v2 05/11] sound: Add a driver for max98088 Simon Glass
2018-12-17 8:00 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 06/11] spring: Update sound to use max98088 codec Simon Glass
2018-12-17 8:00 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 07/11] spring: Update flashmap details Simon Glass
2018-12-17 8:01 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 08/11] samsung: Drop board_enable_audio_codec() Simon Glass
2018-12-17 7:53 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 09/11] samsung: mmc: Drop old MMC init code Simon Glass
2018-12-17 7:54 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 10/11] fdt: samsung: Drop unused fdt_compat_id values Simon Glass
2018-12-17 7:54 ` Lukasz Majewski
2018-12-17 2:36 ` [U-Boot] [PATCH v2 11/11] fdt: tegra: Drop COMPAT_AMS_AS3722 Simon Glass
2018-12-17 7:54 ` Lukasz Majewski
2018-12-21 0:40 ` [U-Boot] [PATCH v2 00/11] samsung: Tidy up sound, DM_MMC drop dead code Minkyu Kang
2018-12-21 17:35 ` Simon Glass
2019-01-16 21:42 ` Simon Glass
2019-01-17 1:09 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217084848.232c9f29@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox