public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 08/11] samsung: Drop board_enable_audio_codec()
Date: Mon, 17 Dec 2018 08:53:29 +0100	[thread overview]
Message-ID: <20181217085329.13b712ef@jawa> (raw)
In-Reply-To: <20181217023638.39803-9-sjg@chromium.org>

On Sun, 16 Dec 2018 19:36:35 -0700
Simon Glass <sjg@chromium.org> wrote:

> This function is not needed now since the audio codecs have been
> converted to proper drivers. The codec-enable GPIO is handled there.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v2: None
> 
>  board/samsung/common/exynos5-dt.c | 29 -----------------------------
>  1 file changed, 29 deletions(-)
> 
> diff --git a/board/samsung/common/exynos5-dt.c
> b/board/samsung/common/exynos5-dt.c index c183965b92a..87eb381345d
> 100644 --- a/board/samsung/common/exynos5-dt.c
> +++ b/board/samsung/common/exynos5-dt.c
> @@ -34,37 +34,8 @@
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> -static void board_enable_audio_codec(void)
> -{
> -	int node, ret;
> -	struct gpio_desc en_gpio;
> -
> -	node = fdtdec_next_compatible(gd->fdt_blob, 0,
> -		COMPAT_SAMSUNG_EXYNOS5_SOUND);
> -	if (node <= 0)
> -		return;
> -
> -	ret = gpio_request_by_name_nodev(offset_to_ofnode(node),
> -					 "codec-enable-gpio", 0,
> &en_gpio,
> -					 GPIOD_IS_OUT |
> GPIOD_IS_OUT_ACTIVE);
> -	if (ret == -FDT_ERR_NOTFOUND)
> -		return;
> -
> -	/* Turn on the GPIO which connects to the codec's "enable"
> line. */
> -	gpio_set_pull(gpio_get_number(&en_gpio), S5P_GPIO_PULL_NONE);
> -
> -#ifdef CONFIG_SOUND_MAX98095
> -	/* Enable MAX98095 Codec */
> -	gpio_request(EXYNOS5_GPIO_X17, "max98095_enable");
> -	gpio_direction_output(EXYNOS5_GPIO_X17, 1);
> -	gpio_set_pull(EXYNOS5_GPIO_X17, S5P_GPIO_PULL_NONE);
> -#endif
> -}
> -
>  int exynos_init(void)
>  {
> -	board_enable_audio_codec();
> -
>  	return 0;
>  }
>  

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181217/e628eed3/attachment.sig>

  reply	other threads:[~2018-12-17  7:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181217023702epcas3p1209a5ebb75a242bf9fa217a39bc13fb8@epcas3p1.samsung.com>
2018-12-17  2:36 ` [U-Boot] [PATCH v2 00/11] samsung: Tidy up sound, DM_MMC drop dead code Simon Glass
2018-12-17  2:36   ` [U-Boot] [PATCH v2 01/11] odroid: Resync defconfigs Simon Glass
2018-12-17  7:46     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 02/11] Convert CONFIG_BOARD_TYPES to Kconfig Simon Glass
2018-12-17  7:46     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 03/11] exynos: Drop duplicate 'model' line Simon Glass
2018-12-17  7:47     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 04/11] exynos: Convert to use CONFIG_BLK Simon Glass
2018-12-17  7:48     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 05/11] sound: Add a driver for max98088 Simon Glass
2018-12-17  8:00     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 06/11] spring: Update sound to use max98088 codec Simon Glass
2018-12-17  8:00     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 07/11] spring: Update flashmap details Simon Glass
2018-12-17  8:01     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 08/11] samsung: Drop board_enable_audio_codec() Simon Glass
2018-12-17  7:53     ` Lukasz Majewski [this message]
2018-12-17  2:36   ` [U-Boot] [PATCH v2 09/11] samsung: mmc: Drop old MMC init code Simon Glass
2018-12-17  7:54     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 10/11] fdt: samsung: Drop unused fdt_compat_id values Simon Glass
2018-12-17  7:54     ` Lukasz Majewski
2018-12-17  2:36   ` [U-Boot] [PATCH v2 11/11] fdt: tegra: Drop COMPAT_AMS_AS3722 Simon Glass
2018-12-17  7:54     ` Lukasz Majewski
2018-12-21  0:40   ` [U-Boot] [PATCH v2 00/11] samsung: Tidy up sound, DM_MMC drop dead code Minkyu Kang
2018-12-21 17:35     ` Simon Glass
2019-01-16 21:42       ` Simon Glass
2019-01-17  1:09         ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217085329.13b712ef@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox