From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] env: sf: fix environment in SPI NOR
Date: Fri, 18 Jan 2019 21:54:07 -0500 [thread overview]
Message-ID: <20190119025407.GT27429@bill-the-cat> (raw)
In-Reply-To: <20190118094556.1542119-1-hs@denx.de>
On Fri, Jan 18, 2019 at 10:45:56AM +0100, Heiko Schocher wrote:
> commit 9a9d66f5eff0 ("env: add spi_flash_read_env function")
>
> breaks Environment functionality, as it reads only
> until 2 \0 are found, but fills the buffer with 0x0
> instead 0xff which leads in an incorrect crc sum.
>
> Fix: init the read buffer with 0xff instead 0x00
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190118/2a77eaa6/attachment.sig>
next prev parent reply other threads:[~2019-01-19 2:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:45 [U-Boot] [PATCH] env: sf: fix environment in SPI NOR Heiko Schocher
2019-01-19 2:54 ` Tom Rini [this message]
2019-01-21 9:53 ` [U-Boot] " Heiko Schocher
2019-01-21 15:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119025407.GT27429@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox