From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] env: sf: fix environment in SPI NOR
Date: Mon, 21 Jan 2019 10:46:20 -0500 [thread overview]
Message-ID: <20190121154620.GD18346@bill-the-cat> (raw)
In-Reply-To: <a9835dbb-6bce-c1a6-e91a-0bf84f09f943@denx.de>
On Mon, Jan 21, 2019 at 10:53:12AM +0100, Heiko Schocher wrote:
> Hello Tom,
>
> Am 19.01.2019 um 03:54 schrieb Tom Rini:
> >On Fri, Jan 18, 2019 at 10:45:56AM +0100, Heiko Schocher wrote:
> >
> >>commit 9a9d66f5eff0 ("env: add spi_flash_read_env function")
> >>
> >>breaks Environment functionality, as it reads only
> >>until 2 \0 are found, but fills the buffer with 0x0
> >>instead 0xff which leads in an incorrect crc sum.
> >>
> >>Fix: init the read buffer with 0xff instead 0x00
> >>
> >>Signed-off-by: Heiko Schocher <hs@denx.de>
> >
> >Applied to u-boot/master, thanks!
>
> I am sorry, this patch was nonsense. After erasing the flash, and
> saving a default Environment, the CONFIG_ENV_SIZE bytes are filled
> with 0x00. So the memset with 0x00 should be OK. I have no idea
> what gone wrong on my board :-(
>
> I am not sure what gone wrong here, so, please can you revert this
> patch?
OK, thanks!
>
> bye,
> Heiko
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190121/e9ffd9ff/attachment.sig>
prev parent reply other threads:[~2019-01-21 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:45 [U-Boot] [PATCH] env: sf: fix environment in SPI NOR Heiko Schocher
2019-01-19 2:54 ` [U-Boot] " Tom Rini
2019-01-21 9:53 ` Heiko Schocher
2019-01-21 15:46 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121154620.GD18346@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox