From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Commit "ARM: CPU: arm926ejs: Consolidate cache routines to common file" breaks u-boot on Dreamplug
Date: Thu, 28 Feb 2019 18:55:41 -0500 [thread overview]
Message-ID: <20190228235541.GU12046@bill-the-cat> (raw)
In-Reply-To: <dd033377106d70df41a6b16c9ef005a3@solinno.co.uk>
On Wed, Feb 27, 2019 at 11:32:16AM +0000, Leigh Brown wrote:
> Hello,
>
> Vagrant Cascadian asked for people to test the version of u-boot packaged
> for Debian Buster. I tested u-boot on my Dreamplug and found it was not
> working correctly. I raised a bug for Debian[1] but I have also tested
> with the mainline version of u-boot and found the same issues.
>
> The first issue is that the following commit caused u-boot to no longer
> be able to access usb storage on the Dreamplug:
>
> commit 93b283d49f933f95f3a6f40762936f454ac655a8
> Author: Adam Ford <aford173@gmail.com>
> Date: Thu Aug 16 13:23:11 2018 -0500
>
> ARM: CPU: arm926ejs: Consolidate cache routines to common file
>
> Four different boards had different options for enabling cache
> that were virtually all the same. This consolidates these
> common functions into arch/arm/cpu/arm926ejs/cache.c
>
> This also has the positive side-effect of enabling cache on
> the Davinci (da850) boards.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> [trini: Add mach-at91 to the list of consolidations]
> Signed-off-by: Tom Rini <trini@konsulko.com>
>
> I don't have much knowledge of ARM caching, but the following patch makes
> it work again on my Dreamplug.
>
> diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c
> index d54de53f31..8a065d73ae 100644
Thanks for digging into this. Based on the whole thread, yes, this
makes sense.
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190228/e6c8caab/attachment.sig>
prev parent reply other threads:[~2019-02-28 23:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 11:32 [U-Boot] Commit "ARM: CPU: arm926ejs: Consolidate cache routines to common file" breaks u-boot on Dreamplug Leigh Brown
2019-02-27 12:50 ` Adam Ford
2019-02-27 14:52 ` Leigh Brown
2019-02-27 15:21 ` Adam Ford
2019-02-28 8:24 ` Chris Packham
2019-02-28 23:55 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228235541.GU12046@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox