* [U-Boot] [PATCH 2/2] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C
2019-03-15 17:11 ` [U-Boot] [PATCH 1/2] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT Krzysztof Kozlowski
@ 2019-03-15 17:11 ` Krzysztof Kozlowski
2019-03-22 7:53 ` Simon Glass
2019-03-30 21:19 ` [U-Boot] [PATCH 1/2] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT Simon Glass
2019-05-09 8:19 ` Minkyu Kang
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2019-03-15 17:11 UTC (permalink / raw)
To: u-boot
The CONFIG_POWER and CONFIG_POWER_I2C were introduced in
include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix
build break by adding CONFIG_POWER") and then it propagated up to
include/configs/arndale.h. However before that commit, there was no
build break at all on Arndale and SMDK5250 boards. It seems the commit
fixed nothing and just added unused defines.
In fact, the Arndale board is not configuring its PMIC (S5M8767) which
uses I2C bus.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested on Arndale board. Testing is welcomed.
---
include/configs/arndale.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/include/configs/arndale.h b/include/configs/arndale.h
index 06b02ce90a94..3d0ce471a42c 100644
--- a/include/configs/arndale.h
+++ b/include/configs/arndale.h
@@ -32,10 +32,6 @@
#define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_STACK
-/* PMIC */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
-
#define CONFIG_PREBOOT
#define CONFIG_S5P_PA_SYSRAM 0x02020000
@@ -44,8 +40,4 @@
/* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */
#define CONFIG_ARM_GIC_BASE_ADDRESS 0x10480000
-/* Power */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
-
#endif /* __CONFIG_H */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH 2/2] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C
2019-03-15 17:11 ` [U-Boot] [PATCH 2/2] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C Krzysztof Kozlowski
@ 2019-03-22 7:53 ` Simon Glass
0 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2019-03-22 7:53 UTC (permalink / raw)
To: u-boot
On Sat, 16 Mar 2019 at 01:13, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The CONFIG_POWER and CONFIG_POWER_I2C were introduced in
> include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix
> build break by adding CONFIG_POWER") and then it propagated up to
> include/configs/arndale.h. However before that commit, there was no
> build break at all on Arndale and SMDK5250 boards. It seems the commit
> fixed nothing and just added unused defines.
>
> In fact, the Arndale board is not configuring its PMIC (S5M8767) which
> uses I2C bus.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Not tested on Arndale board. Testing is welcomed.
> ---
> include/configs/arndale.h | 8 --------
> 1 file changed, 8 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT
2019-03-15 17:11 ` [U-Boot] [PATCH 1/2] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT Krzysztof Kozlowski
2019-03-15 17:11 ` [U-Boot] [PATCH 2/2] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C Krzysztof Kozlowski
@ 2019-03-30 21:19 ` Simon Glass
2019-05-09 8:19 ` Minkyu Kang
2 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2019-03-30 21:19 UTC (permalink / raw)
To: u-boot
On Fri, 15 Mar 2019 at 11:13, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The CONFIG_DM_I2C_COMPAT was introduced in
> include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5:
> enable dm i2c") and then it propagated up to configs/arndale_defconfig.
> However since beginning the Arndale board (Exynos5250) was not using
> I2C.
>
> In fact, the Arndale board is not configuring its PMIC (S5M8767) which
> uses I2C bus. This setting can be thus safely removed to fix build
> warning:
>
> This board uses CONFIG_DM_I2C_COMPAT. Please remove
> (possibly in a subsequent patch in your series)
> before sending patches to the mailing list.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Not tested on Arndale board. Testing is welcomed.
> ---
> configs/arndale_defconfig | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH 1/2] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT
2019-03-15 17:11 ` [U-Boot] [PATCH 1/2] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT Krzysztof Kozlowski
2019-03-15 17:11 ` [U-Boot] [PATCH 2/2] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C Krzysztof Kozlowski
2019-03-30 21:19 ` [U-Boot] [PATCH 1/2] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT Simon Glass
@ 2019-05-09 8:19 ` Minkyu Kang
2 siblings, 0 replies; 5+ messages in thread
From: Minkyu Kang @ 2019-05-09 8:19 UTC (permalink / raw)
To: u-boot
Dear Krzysztof Kozlowski,
On 16/03/2019 02:11, Krzysztof Kozlowski wrote:
> The CONFIG_DM_I2C_COMPAT was introduced in
> include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5:
> enable dm i2c") and then it propagated up to configs/arndale_defconfig.
> However since beginning the Arndale board (Exynos5250) was not using
> I2C.
>
> In fact, the Arndale board is not configuring its PMIC (S5M8767) which
> uses I2C bus. This setting can be thus safely removed to fix build
> warning:
>
> This board uses CONFIG_DM_I2C_COMPAT. Please remove
> (possibly in a subsequent patch in your series)
> before sending patches to the mailing list.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Not tested on Arndale board. Testing is welcomed.
> ---
> configs/arndale_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig
> index 24422645cbac..2f218e8bb64c 100644
> --- a/configs/arndale_defconfig
> +++ b/configs/arndale_defconfig
> @@ -24,7 +24,6 @@ CONFIG_CMD_SOUND=y
> CONFIG_CMD_EXT4_WRITE=y
> CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale"
> CONFIG_ENV_IS_IN_MMC=y
> -CONFIG_DM_I2C_COMPAT=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_S5P=y
>
Sorry to late response.
Could you please rebase this patch series?
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 5+ messages in thread