* [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858
@ 2019-03-22 16:02 Philippe Reynes
2019-03-22 16:02 ` [U-Boot] [PATCH V2 2/8] dt: bcm6858: add led controller Philippe Reynes
` (8 more replies)
0 siblings, 9 replies; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
The driver add the support of the led IP on bcm6858.
This led IP can drive up to 32 leds, and can handle
blinking.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- use const for array bcm6858_flash_rate (thanks Daniel)
- use int for array bcm6858_flash_rate (thanks Daniel)
doc/device-tree-bindings/leds/leds-bcm6858.txt | 51 +++++
drivers/led/Kconfig | 7 +
drivers/led/Makefile | 1 +
drivers/led/led_bcm6858.c | 250 +++++++++++++++++++++++++
4 files changed, 309 insertions(+)
create mode 100644 doc/device-tree-bindings/leds/leds-bcm6858.txt
create mode 100644 drivers/led/led_bcm6858.c
diff --git a/doc/device-tree-bindings/leds/leds-bcm6858.txt b/doc/device-tree-bindings/leds/leds-bcm6858.txt
new file mode 100644
index 0000000..ea2fe23
--- /dev/null
+++ b/doc/device-tree-bindings/leds/leds-bcm6858.txt
@@ -0,0 +1,51 @@
+LEDs connected to Broadcom BCM6858 controller
+
+This controller is present on BCM6858, BCM6328, BCM6362 and BCM63268.
+In these SoCs it's possible to control LEDs both as GPIOs or by hardware.
+
+Required properties:
+ - compatible : should be "brcm,bcm6858-leds".
+ - #address-cells : must be 1.
+ - #size-cells : must be 0.
+ - reg : BCM6858 LED controller address and size.
+
+Optional properties:
+ - brcm,serial-led-msb-first : Boolean, msb data come out first on serial data pin
+ Default : false
+ - brcm,serial-led-en-pol : Boolean, serial led polarity (true => active high)
+ Default : false
+ - brcm,serial-led-clk-pol : Boolean, serial clock polarity (true => active high)
+ Default : false
+ - brcm,serial-led-data-ppol : Boolean, serial data polarity (true => active high)
+ Default : false
+ - brcm,serial-shift-inv : Boolean, led test mode
+ Default : false
+
+Each LED is represented as a sub-node of the brcm,bcm6858-leds device.
+
+LED sub-node required properties:
+ - reg : LED pin number (only LEDs 0 to 32 are valid).
+
+LED sub-node optional properties:
+ - label : see Documentation/devicetree/bindings/leds/common.txt
+ - active-low : Boolean, makes LED active low.
+ Default : false
+
+Examples:
+BCM6328 with 2 GPIO LEDs
+ leds0: led-controller at ff800800 {
+ compatible = "brcm,bcm6858-leds";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0xff800800 0x0 0xe4>;
+
+ led at 2 {
+ reg = <2>;
+ label = "green:inet";
+ };
+
+ led at 5 {
+ reg = <5>;
+ label = "red:alarm";
+ };
+ };
diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
index 5da5c4a..4c8582d 100644
--- a/drivers/led/Kconfig
+++ b/drivers/led/Kconfig
@@ -28,6 +28,13 @@ config LED_BCM6358
LED HW controller accessed via MMIO registers.
HW has no blinking capabilities and up to 32 LEDs can be controlled.
+config LED_BCM6858
+ bool "LED Support for BCM6858"
+ depends on LED && ARCH_BCM6858
+ help
+ This option enables support for LEDs connected to the BCM6858
+ HW has blinking capabilities and up to 32 LEDs can be controlled.
+
config LED_BLINK
bool "Support LED blinking"
depends on LED
diff --git a/drivers/led/Makefile b/drivers/led/Makefile
index 160a8f3..3654dd3 100644
--- a/drivers/led/Makefile
+++ b/drivers/led/Makefile
@@ -6,4 +6,5 @@
obj-y += led-uclass.o
obj-$(CONFIG_LED_BCM6328) += led_bcm6328.o
obj-$(CONFIG_LED_BCM6358) += led_bcm6358.o
+obj-$(CONFIG_LED_BCM6858) += led_bcm6858.o
obj-$(CONFIG_$(SPL_)LED_GPIO) += led_gpio.o
diff --git a/drivers/led/led_bcm6858.c b/drivers/led/led_bcm6858.c
new file mode 100644
index 0000000..27a76fc
--- /dev/null
+++ b/drivers/led/led_bcm6858.c
@@ -0,0 +1,250 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Philippe Reynes <philippe.reynes@softathome.com>
+ *
+ * based on:
+ * drivers/led/led_bcm6328.c
+ * drivers/led/led_bcm6358.c
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <errno.h>
+#include <led.h>
+#include <asm/io.h>
+#include <dm/lists.h>
+
+#define LEDS_MAX 32
+#define LEDS_WAIT 100
+
+/* LED Mode register */
+#define LED_MODE_REG 0x0
+#define LED_MODE_OFF 0
+#define LED_MODE_ON 1
+#define LED_MODE_MASK 1
+
+/* LED Controller Global settings register */
+#define LED_CTRL_REG 0x00
+#define LED_CTRL_MASK 0x1f
+#define LED_CTRL_LED_TEST_MODE BIT(0)
+#define LED_CTRL_SERIAL_LED_DATA_PPOL BIT(1)
+#define LED_CTRL_SERIAL_LED_CLK_POL BIT(2)
+#define LED_CTRL_SERIAL_LED_EN_POL BIT(3)
+#define LED_CTRL_SERIAL_LED_MSB_FIRST BIT(4)
+
+/* LED Controller IP LED source select register */
+#define LED_HW_LED_EN_REG 0x08
+/* LED Flash control register0 */
+#define LED_FLASH_RATE_CONTROL_REG0 0x10
+/* Soft LED input register */
+#define LED_SW_LED_IP_REG 0xb8
+/* Soft LED input polarity register */
+#define LED_SW_LED_IP_PPOL_REG 0xbc
+
+struct bcm6858_led_priv {
+ void __iomem *regs;
+ u8 pin;
+};
+
+#ifdef CONFIG_LED_BLINK
+/*
+ * The value for flash rate are:
+ * 0 : no blinking
+ * 1 : rate is 25 Hz => 40 ms (period)
+ * 2 : rate is 12.5 Hz => 80 ms (period)
+ * 3 : rate is 6.25 Hz => 160 ms (period)
+ * 4 : rate is 3.125 Hz => 320 ms (period)
+ * 5 : rate is 1.5625 Hz => 640 ms (period)
+ * 6 : rate is 0.7815 Hz => 1280 ms (period)
+ * 7 : rate is 0.390625 Hz => 2560 ms (period)
+ */
+static const int bcm6858_flash_rate[8] = {
+ 0, 40, 80, 160, 320, 640, 1280, 2560
+};
+
+static u32 bcm6858_flash_rate_value(int period_ms)
+{
+ unsigned long value = 7;
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(bcm6858_flash_rate); i++) {
+ if (period_ms <= bcm6858_flash_rate[i]) {
+ value = i;
+ break;
+ }
+ }
+
+ return value;
+}
+
+static int bcm6858_led_set_period(struct udevice *dev, int period_ms)
+{
+ struct bcm6858_led_priv *priv = dev_get_priv(dev);
+ u32 offset, shift, mask, value;
+
+ offset = (priv->pin / 8) * 4;
+ shift = (priv->pin % 8) * 4;
+ mask = 0x7 << shift;
+ value = bcm6858_flash_rate_value(period_ms) << shift;
+
+ clrbits_32(priv->regs + LED_FLASH_RATE_CONTROL_REG0 + offset, mask);
+ setbits_32(priv->regs + LED_FLASH_RATE_CONTROL_REG0 + offset, value);
+
+ return 0;
+}
+#endif
+
+static enum led_state_t bcm6858_led_get_state(struct udevice *dev)
+{
+ struct bcm6858_led_priv *priv = dev_get_priv(dev);
+ enum led_state_t state = LEDST_OFF;
+ u32 sw_led_ip;
+
+ sw_led_ip = readl(priv->regs + LED_SW_LED_IP_REG);
+ if (sw_led_ip & (1 << priv->pin))
+ state = LEDST_ON;
+
+ return state;
+}
+
+static int bcm6858_led_set_state(struct udevice *dev, enum led_state_t state)
+{
+ struct bcm6858_led_priv *priv = dev_get_priv(dev);
+
+ switch (state) {
+ case LEDST_OFF:
+ clrbits_32(priv->regs + LED_SW_LED_IP_REG, (1 << priv->pin));
+#ifdef CONFIG_LED_BLINK
+ bcm6858_led_set_period(dev, 0);
+#endif
+ break;
+ case LEDST_ON:
+ setbits_32(priv->regs + LED_SW_LED_IP_REG, (1 << priv->pin));
+#ifdef CONFIG_LED_BLINK
+ bcm6858_led_set_period(dev, 0);
+#endif
+ break;
+ case LEDST_TOGGLE:
+ if (bcm6858_led_get_state(dev) == LEDST_OFF)
+ return bcm6858_led_set_state(dev, LEDST_ON);
+ else
+ return bcm6858_led_set_state(dev, LEDST_OFF);
+ break;
+#ifdef CONFIG_LED_BLINK
+ case LEDST_BLINK:
+ setbits_32(priv->regs + LED_SW_LED_IP_REG, (1 << priv->pin));
+ break;
+#endif
+ default:
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static const struct led_ops bcm6858_led_ops = {
+ .get_state = bcm6858_led_get_state,
+ .set_state = bcm6858_led_set_state,
+#ifdef CONFIG_LED_BLINK
+ .set_period = bcm6858_led_set_period,
+#endif
+};
+
+static int bcm6858_led_probe(struct udevice *dev)
+{
+ struct led_uc_plat *uc_plat = dev_get_uclass_platdata(dev);
+
+ /* Top-level LED node */
+ if (!uc_plat->label) {
+ void __iomem *regs;
+ u32 set_bits = 0;
+
+ regs = dev_remap_addr(dev);
+ if (!regs)
+ return -EINVAL;
+
+ if (dev_read_bool(dev, "brcm,serial-led-msb-first"))
+ set_bits |= LED_CTRL_SERIAL_LED_MSB_FIRST;
+ if (dev_read_bool(dev, "brcm,serial-led-en-pol"))
+ set_bits |= LED_CTRL_SERIAL_LED_EN_POL;
+ if (dev_read_bool(dev, "brcm,serial-led-clk-pol"))
+ set_bits |= LED_CTRL_SERIAL_LED_CLK_POL;
+ if (dev_read_bool(dev, "brcm,serial-led-data-ppol"))
+ set_bits |= LED_CTRL_SERIAL_LED_DATA_PPOL;
+ if (dev_read_bool(dev, "brcm,led-test-mode"))
+ set_bits |= LED_CTRL_LED_TEST_MODE;
+
+ clrsetbits_32(regs + LED_CTRL_REG, ~0, set_bits);
+ } else {
+ struct bcm6858_led_priv *priv = dev_get_priv(dev);
+ void __iomem *regs;
+ unsigned int pin;
+
+ regs = dev_remap_addr(dev_get_parent(dev));
+ if (!regs)
+ return -EINVAL;
+
+ pin = dev_read_u32_default(dev, "reg", LEDS_MAX);
+ if (pin >= LEDS_MAX)
+ return -EINVAL;
+
+ priv->regs = regs;
+ priv->pin = pin;
+
+ /* this led is managed by software */
+ clrbits_32(regs + LED_HW_LED_EN_REG, 1 << pin);
+
+ /* configure the polarity */
+ if (dev_read_bool(dev, "active-low"))
+ clrbits_32(regs + LED_SW_LED_IP_PPOL_REG, 1 << pin);
+ else
+ setbits_32(regs + LED_SW_LED_IP_PPOL_REG, 1 << pin);
+ }
+
+ return 0;
+}
+
+static int bcm6858_led_bind(struct udevice *parent)
+{
+ ofnode node;
+
+ dev_for_each_subnode(node, parent) {
+ struct led_uc_plat *uc_plat;
+ struct udevice *dev;
+ const char *label;
+ int ret;
+
+ label = ofnode_read_string(node, "label");
+ if (!label) {
+ debug("%s: node %s has no label\n", __func__,
+ ofnode_get_name(node));
+ return -EINVAL;
+ }
+
+ ret = device_bind_driver_to_node(parent, "bcm6858-led",
+ ofnode_get_name(node),
+ node, &dev);
+ if (ret)
+ return ret;
+
+ uc_plat = dev_get_uclass_platdata(dev);
+ uc_plat->label = label;
+ }
+
+ return 0;
+}
+
+static const struct udevice_id bcm6858_led_ids[] = {
+ { .compatible = "brcm,bcm6858-leds" },
+ { /* sentinel */ }
+};
+
+U_BOOT_DRIVER(bcm6858_led) = {
+ .name = "bcm6858-led",
+ .id = UCLASS_LED,
+ .of_match = bcm6858_led_ids,
+ .bind = bcm6858_led_bind,
+ .probe = bcm6858_led_probe,
+ .priv_auto_alloc_size = sizeof(struct bcm6858_led_priv),
+ .ops = &bcm6858_led_ops,
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 2/8] dt: bcm6858: add led controller
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
@ 2019-03-22 16:02 ` Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot,V2,2/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 3/8] dt: bcm968580xref: enable " Philippe Reynes
` (7 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
Add the led controller in the bcm6858 device tree.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- no change
arch/arm/dts/bcm6858.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/dts/bcm6858.dtsi b/arch/arm/dts/bcm6858.dtsi
index 23b80c6..0359417 100644
--- a/arch/arm/dts/bcm6858.dtsi
+++ b/arch/arm/dts/bcm6858.dtsi
@@ -82,6 +82,13 @@
status = "disabled";
};
+ leds: led-controller at ff800800 {
+ compatible = "brcm,bcm6858-leds";
+ reg = <0x0 0xff800800 0x0 0xe4>;
+
+ status = "disabled";
+ };
+
wdt1: watchdog at ff802780 {
compatible = "brcm,bcm6345-wdt";
reg = <0x0 0xff802780 0x0 0x14>;
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 3/8] dt: bcm968580xref: enable led controller
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
2019-03-22 16:02 ` [U-Boot] [PATCH V2 2/8] dt: bcm6858: add led controller Philippe Reynes
@ 2019-03-22 16:02 ` Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot, V2, " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 4/8] bcm968580xref: enable led support Philippe Reynes
` (6 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
Enable the led controller in the device tree
of the board bcm968580xref.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- no change
arch/arm/dts/bcm968580xref.dts | 48 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm/dts/bcm968580xref.dts b/arch/arm/dts/bcm968580xref.dts
index 0c59f94..c11246a 100644
--- a/arch/arm/dts/bcm968580xref.dts
+++ b/arch/arm/dts/bcm968580xref.dts
@@ -29,3 +29,51 @@
u-boot,dm-pre-reloc;
status = "okay";
};
+
+&leds {
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ brcm,serial-led-en-pol;
+ brcm,serial-led-data-ppol;
+
+ led at 2 {
+ reg = <2>;
+ label = "green:inet";
+ };
+
+ led at 5 {
+ reg = <5>;
+ label = "red:alarm";
+ };
+
+ led at 8 {
+ reg = <8>;
+ label = "green:wlan_link";
+ };
+
+ led at 11 {
+ reg = <11>;
+ label = "green:fxs1";
+ };
+
+ led at 14 {
+ reg = <14>;
+ label = "green:fxs2";
+ };
+
+ led at 15 {
+ reg = <15>;
+ label = "green:usb0";
+ };
+
+ led at 16 {
+ reg = <16>;
+ label = "green:usb1";
+ };
+
+ led at 17 {
+ reg = <17>;
+ label = "green:wps";
+ };
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 4/8] bcm968580xref: enable led support
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
2019-03-22 16:02 ` [U-Boot] [PATCH V2 2/8] dt: bcm6858: add led controller Philippe Reynes
2019-03-22 16:02 ` [U-Boot] [PATCH V2 3/8] dt: bcm968580xref: enable " Philippe Reynes
@ 2019-03-22 16:02 ` Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot,V2,4/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 5/8] led: bcm6858: allow to use this driver on ARCH_963158 Philippe Reynes
` (5 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
Enable the led support in the configuration
of the board bcm968580xref.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- no change
configs/bcm968580xref_ram_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/bcm968580xref_ram_defconfig b/configs/bcm968580xref_ram_defconfig
index e8cb3a0..887ccb8 100644
--- a/configs/bcm968580xref_ram_defconfig
+++ b/configs/bcm968580xref_ram_defconfig
@@ -22,6 +22,9 @@ CONFIG_DEFAULT_DEVICE_TREE="bcm968580xref"
# CONFIG_NET is not set
CONFIG_BLK=y
CONFIG_CLK=y
+CONFIG_LED=y
+CONFIG_LED_BCM6858=y
+CONFIG_LED_BLINK=y
# CONFIG_MMC is not set
CONFIG_SPECIFY_CONSOLE_INDEX=y
# CONFIG_SPL_SERIAL_PRESENT is not set
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 5/8] led: bcm6858: allow to use this driver on ARCH_963158
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
` (2 preceding siblings ...)
2019-03-22 16:02 ` [U-Boot] [PATCH V2 4/8] bcm968580xref: enable led support Philippe Reynes
@ 2019-03-22 16:02 ` Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot, V2, " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 6/8] dt: bcm63158: add led controller Philippe Reynes
` (4 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
Allow the led bcm6858 driver to be used on bcm63158.
They have the same led controller.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- no change
drivers/led/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
index 4c8582d..5643939 100644
--- a/drivers/led/Kconfig
+++ b/drivers/led/Kconfig
@@ -30,7 +30,7 @@ config LED_BCM6358
config LED_BCM6858
bool "LED Support for BCM6858"
- depends on LED && ARCH_BCM6858
+ depends on LED && (ARCH_BCM6858 || ARCH_BCM63158)
help
This option enables support for LEDs connected to the BCM6858
HW has blinking capabilities and up to 32 LEDs can be controlled.
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 6/8] dt: bcm63158: add led controller
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
` (3 preceding siblings ...)
2019-03-22 16:02 ` [U-Boot] [PATCH V2 5/8] led: bcm6858: allow to use this driver on ARCH_963158 Philippe Reynes
@ 2019-03-22 16:02 ` Philippe Reynes
2019-04-24 13:29 ` [U-Boot] [U-Boot,V2,6/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 7/8] dt: bcm963158: enable " Philippe Reynes
` (3 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
Add the led controller in the bcm63158 device tree.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- no change
arch/arm/dts/bcm63158.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/dts/bcm63158.dtsi b/arch/arm/dts/bcm63158.dtsi
index 6a3fbc9..0967a3d 100644
--- a/arch/arm/dts/bcm63158.dtsi
+++ b/arch/arm/dts/bcm63158.dtsi
@@ -82,6 +82,13 @@
status = "disabled";
};
+ leds: led-controller at ff800800 {
+ compatible = "brcm,bcm6858-leds";
+ reg = <0x0 0xff800800 0x0 0xe4>;
+
+ status = "disabled";
+ };
+
wdt1: watchdog at ff800480 {
compatible = "brcm,bcm6345-wdt";
reg = <0x0 0xff800480 0x0 0x14>;
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 7/8] dt: bcm963158: enable led controller
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
` (4 preceding siblings ...)
2019-03-22 16:02 ` [U-Boot] [PATCH V2 6/8] dt: bcm63158: add led controller Philippe Reynes
@ 2019-03-22 16:02 ` Philippe Reynes
2019-04-24 13:29 ` [U-Boot] [U-Boot,V2,7/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 8/8] bcm963158: enable led support Philippe Reynes
` (2 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
Enable the led controller in the device tree
of the board bcm963158.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- no change
arch/arm/dts/bcm963158.dts | 49 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/arch/arm/dts/bcm963158.dts b/arch/arm/dts/bcm963158.dts
index dc5afb5..15e87de 100644
--- a/arch/arm/dts/bcm963158.dts
+++ b/arch/arm/dts/bcm963158.dts
@@ -29,3 +29,52 @@
u-boot,dm-pre-reloc;
status = "okay";
};
+
+&leds {
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ brcm,serial-led-en-pol;
+ brcm,serial-led-data-ppol;
+
+ led at 16 {
+ reg = <16>;
+ label = "red:dsl2";
+ };
+
+ led at 17 {
+ reg = <17>;
+ label = "green:dsl1";
+ };
+
+ led at 18 {
+ reg = <18>;
+ label = "green:fxs2";
+ };
+
+ led at 19 {
+ reg = <19>;
+ label = "green:fxs1";
+ };
+
+ led at 26 {
+ reg = <26>;
+ label = "green:wan1_act";
+ };
+
+ led at 27 {
+ reg = <27>;
+ label = "green:wps";
+ };
+
+ led at 28 {
+ reg = <28>;
+ active-low;
+ label = "green:aggregate_act";
+ };
+
+ led at 29 {
+ reg = <29>;
+ label = "green:aggregate_link";
+ };
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 8/8] bcm963158: enable led support
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
` (5 preceding siblings ...)
2019-03-22 16:02 ` [U-Boot] [PATCH V2 7/8] dt: bcm963158: enable " Philippe Reynes
@ 2019-03-22 16:02 ` Philippe Reynes
2019-04-24 13:29 ` [U-Boot] [U-Boot,V2,8/8] " Tom Rini
2019-03-29 19:15 ` [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Daniel Schwierzeck
2019-04-24 13:28 ` [U-Boot] [U-Boot,V2,1/8] " Tom Rini
8 siblings, 1 reply; 17+ messages in thread
From: Philippe Reynes @ 2019-03-22 16:02 UTC (permalink / raw)
To: u-boot
Enable the led support in the configuration
of the board bcm963158.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
Changelog:
v2:
- no change
configs/bcm963158_ram_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/bcm963158_ram_defconfig b/configs/bcm963158_ram_defconfig
index fc55e98..c93a8f6 100644
--- a/configs/bcm963158_ram_defconfig
+++ b/configs/bcm963158_ram_defconfig
@@ -28,6 +28,9 @@ CONFIG_DEFAULT_DEVICE_TREE="bcm963158"
# CONFIG_NET is not set
CONFIG_BLK=y
CONFIG_CLK=y
+CONFIG_LED=y
+CONFIG_LED_BCM6858=y
+CONFIG_LED_BLINK=y
# CONFIG_MMC is not set
CONFIG_SPECIFY_CONSOLE_INDEX=y
# CONFIG_SPL_SERIAL_PRESENT is not set
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
` (6 preceding siblings ...)
2019-03-22 16:02 ` [U-Boot] [PATCH V2 8/8] bcm963158: enable led support Philippe Reynes
@ 2019-03-29 19:15 ` Daniel Schwierzeck
2019-04-24 13:28 ` [U-Boot] [U-Boot,V2,1/8] " Tom Rini
8 siblings, 0 replies; 17+ messages in thread
From: Daniel Schwierzeck @ 2019-03-29 19:15 UTC (permalink / raw)
To: u-boot
Am 22.03.19 um 17:02 schrieb Philippe Reynes:
> The driver add the support of the led IP on bcm6858.
> This led IP can drive up to 32 leds, and can handle
> blinking.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
> ---
> Changelog:
> v2:
> - use const for array bcm6858_flash_rate (thanks Daniel)
> - use int for array bcm6858_flash_rate (thanks Daniel)
>
> doc/device-tree-bindings/leds/leds-bcm6858.txt | 51 +++++
> drivers/led/Kconfig | 7 +
> drivers/led/Makefile | 1 +
> drivers/led/led_bcm6858.c | 250 +++++++++++++++++++++++++
> 4 files changed, 309 insertions(+)
> create mode 100644 doc/device-tree-bindings/leds/leds-bcm6858.txt
> create mode 100644 drivers/led/led_bcm6858.c
>
Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
--
- Daniel
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot,V2,1/8] led: add initial support for bcm6858
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
` (7 preceding siblings ...)
2019-03-29 19:15 ` [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Daniel Schwierzeck
@ 2019-04-24 13:28 ` Tom Rini
8 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:28 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:01PM +0100, Philippe Reynes wrote:
> The driver add the support of the led IP on bcm6858.
> This led IP can drive up to 32 leds, and can handle
> blinking.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
> Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/a852976c/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot,V2,2/8] dt: bcm6858: add led controller
2019-03-22 16:02 ` [U-Boot] [PATCH V2 2/8] dt: bcm6858: add led controller Philippe Reynes
@ 2019-04-24 13:28 ` Tom Rini
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:28 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:02PM +0100, Philippe Reynes wrote:
> Add the led controller in the bcm6858 device tree.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/bda731ca/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot, V2, 3/8] dt: bcm968580xref: enable led controller
2019-03-22 16:02 ` [U-Boot] [PATCH V2 3/8] dt: bcm968580xref: enable " Philippe Reynes
@ 2019-04-24 13:28 ` Tom Rini
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:28 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:03PM +0100, Philippe Reynes wrote:
> Enable the led controller in the device tree
> of the board bcm968580xref.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/3481adc6/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot,V2,4/8] bcm968580xref: enable led support
2019-03-22 16:02 ` [U-Boot] [PATCH V2 4/8] bcm968580xref: enable led support Philippe Reynes
@ 2019-04-24 13:28 ` Tom Rini
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:28 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:04PM +0100, Philippe Reynes wrote:
> Enable the led support in the configuration
> of the board bcm968580xref.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/1688cfe9/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot, V2, 5/8] led: bcm6858: allow to use this driver on ARCH_963158
2019-03-22 16:02 ` [U-Boot] [PATCH V2 5/8] led: bcm6858: allow to use this driver on ARCH_963158 Philippe Reynes
@ 2019-04-24 13:28 ` Tom Rini
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:28 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:05PM +0100, Philippe Reynes wrote:
> Allow the led bcm6858 driver to be used on bcm63158.
> They have the same led controller.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/ca59daa7/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot,V2,6/8] dt: bcm63158: add led controller
2019-03-22 16:02 ` [U-Boot] [PATCH V2 6/8] dt: bcm63158: add led controller Philippe Reynes
@ 2019-04-24 13:29 ` Tom Rini
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:29 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:06PM +0100, Philippe Reynes wrote:
> Add the led controller in the bcm63158 device tree.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/c6ace1d4/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot,V2,7/8] dt: bcm963158: enable led controller
2019-03-22 16:02 ` [U-Boot] [PATCH V2 7/8] dt: bcm963158: enable " Philippe Reynes
@ 2019-04-24 13:29 ` Tom Rini
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:29 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:07PM +0100, Philippe Reynes wrote:
> Enable the led controller in the device tree
> of the board bcm963158.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/ef6eff76/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [U-Boot] [U-Boot,V2,8/8] bcm963158: enable led support
2019-03-22 16:02 ` [U-Boot] [PATCH V2 8/8] bcm963158: enable led support Philippe Reynes
@ 2019-04-24 13:29 ` Tom Rini
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rini @ 2019-04-24 13:29 UTC (permalink / raw)
To: u-boot
On Fri, Mar 22, 2019 at 05:02:08PM +0100, Philippe Reynes wrote:
> Enable the led support in the configuration
> of the board bcm963158.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/d5b8b7af/attachment.sig>
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-04-24 13:29 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-22 16:02 [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Philippe Reynes
2019-03-22 16:02 ` [U-Boot] [PATCH V2 2/8] dt: bcm6858: add led controller Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot,V2,2/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 3/8] dt: bcm968580xref: enable " Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot, V2, " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 4/8] bcm968580xref: enable led support Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot,V2,4/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 5/8] led: bcm6858: allow to use this driver on ARCH_963158 Philippe Reynes
2019-04-24 13:28 ` [U-Boot] [U-Boot, V2, " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 6/8] dt: bcm63158: add led controller Philippe Reynes
2019-04-24 13:29 ` [U-Boot] [U-Boot,V2,6/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 7/8] dt: bcm963158: enable " Philippe Reynes
2019-04-24 13:29 ` [U-Boot] [U-Boot,V2,7/8] " Tom Rini
2019-03-22 16:02 ` [U-Boot] [PATCH V2 8/8] bcm963158: enable led support Philippe Reynes
2019-04-24 13:29 ` [U-Boot] [U-Boot,V2,8/8] " Tom Rini
2019-03-29 19:15 ` [U-Boot] [PATCH V2 1/8] led: add initial support for bcm6858 Daniel Schwierzeck
2019-04-24 13:28 ` [U-Boot] [U-Boot,V2,1/8] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox