From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 8/8] ata: ahci: Don't forget to clear upper address regs.
Date: Tue, 20 Aug 2019 12:19:32 -0400 [thread overview]
Message-ID: <20190820161932.GA3562@bill-the-cat> (raw)
In-Reply-To: <20190806150852.5527-9-frank-w@public-files.de>
On Tue, Aug 06, 2019 at 05:08:52PM +0200, Frank Wunderlich wrote:
> From: Oleksandr Rybalko <ray@ddteam.net>
>
> In 32bits mode upper bits need to be set to 0, otherwise controller will
> try to DMA into not existing memory and stops with error.
>
> changes since v2: none
>
> Tested-by: Frank Wunderlich <frank-w@public-files.de>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Signed-off-by: Oleksandr Rybalko <ray@ddteam.net>
This introduces a warning:
x86: w+ qemu-x86_64
+(qemu-x86_64) writel_with_flush((u32)pp->cmd_slot, port_mmio + PORT_LST_ADDR);
+(qemu-x86_64) ^
+(qemu-x86_64) arch/x86/include/asm/io.h:71:53: note: in definition of macro 'writel'
+(qemu-x86_64) #define writel(b, addr) (*(volatile u32 *)(addr) = (b))
+(qemu-x86_64) ^
+(qemu-x86_64) drivers/ata/ahci.c:596:2: note: in expansion of macro 'writel_with_flush'
+(qemu-x86_64) ^~~~~~~~~~~~~~~~~
w+(qemu-x86_64) drivers/ata/ahci.c: In function 'ahci_port_start':
w+(qemu-x86_64) drivers/ata/ahci.c:596:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190820/1a22b641/attachment.sig>
next prev parent reply other threads:[~2019-08-20 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 15:08 [U-Boot] [PATCH v3 0/8] add PCIe, its PHY and AHCI support for mt7623 Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 1/8] pci: mediatek: add PCIe controller support for MT7623 Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 2/8] phy: mediatek: add MediaTek T-PHY support for PCIe Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 3/8] arm: dts: add PCIe controller for MT7623 SoC Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 4/8] arm: dts: split mtk-reset.h into per-chip header Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 5/8] dt-bindings: pcie: add a document for MT7623 PCIe controller Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 6/8] dt-bindings: phy: add a document for MediaTek tphy Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 7/8] ahci-pci: ASM1061 report wrong class, but support AHCI Frank Wunderlich
2019-08-06 15:08 ` [U-Boot] [PATCH v3 8/8] ata: ahci: Don't forget to clear upper address regs Frank Wunderlich
2019-08-20 16:19 ` Tom Rini [this message]
2019-08-20 7:17 ` [U-Boot] [PATCH v3 0/8] add PCIe, its PHY and AHCI support for mt7623 Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820161932.GA3562@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox