* [U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier
@ 2019-08-19 9:10 Andy Shevchenko
2019-08-19 9:18 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-08-19 9:10 UTC (permalink / raw)
To: u-boot
Using ACPI predefined macros, such as Zero or One, will reduce a binary size
of resulting ACPI tables.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/include/asm/arch-tangier/acpi/platform.asl | 2 +-
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/arch-tangier/acpi/platform.asl b/arch/x86/include/asm/arch-tangier/acpi/platform.asl
index bd1aa9ce88..39bcaf3801 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/platform.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/platform.asl
@@ -18,7 +18,7 @@ Method(_PTS, 1)
/* The _WAK method is called on system wakeup */
Method(_WAK, 1)
{
- Return (Package() {0, 0})
+ Return (Package() { Zero, Zero })
}
Scope (\_SB)
diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index bb2a59dbc2..aedc62cc0c 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -10,8 +10,8 @@ Device (PCI0)
Name (_HID, EISAID("PNP0A08")) /* PCIe */
Name (_CID, EISAID("PNP0A03")) /* PCI */
- Name (_ADR, 0)
- Name (_BBN, 0)
+ Name (_ADR, Zero)
+ Name (_BBN, Zero)
Name (MCRS, ResourceTemplate()
{
--
2.23.0.rc1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier
2019-08-19 9:10 [U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier Andy Shevchenko
@ 2019-08-19 9:18 ` Bin Meng
2019-08-26 1:49 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2019-08-19 9:18 UTC (permalink / raw)
To: u-boot
On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> of resulting ACPI tables.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/include/asm/arch-tangier/acpi/platform.asl | 2 +-
> arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier
2019-08-19 9:18 ` Bin Meng
@ 2019-08-26 1:49 ` Bin Meng
2019-08-26 9:43 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2019-08-26 1:49 UTC (permalink / raw)
To: u-boot
Hi Andy,
On Mon, Aug 19, 2019 at 5:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> > of resulting ACPI tables.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > arch/x86/include/asm/arch-tangier/acpi/platform.asl | 2 +-
> > arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Somehow this patch does not apply cleanly on top of latest
u-boot/master, so I manually fixed the issue and
applied to u-boot-x86, thanks!
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier
2019-08-26 1:49 ` Bin Meng
@ 2019-08-26 9:43 ` Andy Shevchenko
2019-08-26 9:47 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-08-26 9:43 UTC (permalink / raw)
To: u-boot
On Mon, Aug 26, 2019 at 09:49:49AM +0800, Bin Meng wrote:
> Hi Andy,
>
> On Mon, Aug 19, 2019 at 5:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> > > of resulting ACPI tables.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > arch/x86/include/asm/arch-tangier/acpi/platform.asl | 2 +-
> > > arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
> > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > >
> >
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> Somehow this patch does not apply cleanly on top of latest
> u-boot/master, so I manually fixed the issue and
>
> applied to u-boot-x86, thanks!
Thanks!
P.S. It seems the subject missed. If you can rebase, it might be worth to fix.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier
2019-08-26 9:43 ` Andy Shevchenko
@ 2019-08-26 9:47 ` Bin Meng
0 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2019-08-26 9:47 UTC (permalink / raw)
To: u-boot
Hi Andy,
On Mon, Aug 26, 2019 at 5:43 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Aug 26, 2019 at 09:49:49AM +0800, Bin Meng wrote:
> > Hi Andy,
> >
> > On Mon, Aug 19, 2019 at 5:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > On Mon, Aug 19, 2019 at 5:17 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > Using ACPI predefined macros, such as Zero or One, will reduce a binary size
> > > > of resulting ACPI tables.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > > > arch/x86/include/asm/arch-tangier/acpi/platform.asl | 2 +-
> > > > arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
> > > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > >
> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Somehow this patch does not apply cleanly on top of latest
> > u-boot/master, so I manually fixed the issue and
> >
> > applied to u-boot-x86, thanks!
>
> Thanks!
>
> P.S. It seems the subject missed. If you can rebase, it might be worth to fix.
>
Ah, yes! Thanks for catching this. I added the commit subject.
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-26 9:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-19 9:10 [U-Boot] [PATCH v1] x86: acpi: Slightly reduce binary size of ACPI tables for Tangier Andy Shevchenko
2019-08-19 9:18 ` Bin Meng
2019-08-26 1:49 ` Bin Meng
2019-08-26 9:43 ` Andy Shevchenko
2019-08-26 9:47 ` Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox