* [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR
@ 2019-10-23 14:20 Fabio Estevam
2019-10-23 14:20 ` [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-10-23 14:20 UTC (permalink / raw)
To: u-boot
warp7 uses the driver model and it retrieves the ESDHC
base address from device tree.
Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
include/configs/warp7.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h
index 73541fe176..9c6ee6997f 100644
--- a/include/configs/warp7.h
+++ b/include/configs/warp7.h
@@ -17,7 +17,6 @@
#define CONFIG_SYS_MALLOC_LEN (35 * SZ_1M)
/* MMC Config*/
-#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
#define CONFIG_SYS_MMC_IMG_LOAD_PART 1
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command
2019-10-23 14:20 [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR Fabio Estevam
@ 2019-10-23 14:20 ` Fabio Estevam
2019-10-23 15:55 ` Pierre-Jean Texier
2019-10-23 17:18 ` Joris Offouga
2019-10-23 15:55 ` [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR Pierre-Jean Texier
2019-10-23 17:49 ` Joris Offouga
2 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-10-23 14:20 UTC (permalink / raw)
To: u-boot
The "mmc dev" command is being called twice.
Remove the extra call.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
include/configs/warp7.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h
index 9c6ee6997f..f1fc6c714f 100644
--- a/include/configs/warp7.h
+++ b/include/configs/warp7.h
@@ -94,7 +94,6 @@
"fi;\0" \
#define CONFIG_BOOTCOMMAND \
- "mmc dev ${mmcdev};" \
"mmc dev ${mmcdev}; if mmc rescan; then " \
"run do_bootscript_hab;" \
"if run loadbootscript; then " \
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command
2019-10-23 14:20 ` [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command Fabio Estevam
@ 2019-10-23 15:55 ` Pierre-Jean Texier
2019-10-23 17:18 ` Joris Offouga
1 sibling, 0 replies; 6+ messages in thread
From: Pierre-Jean Texier @ 2019-10-23 15:55 UTC (permalink / raw)
To: u-boot
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
> The "mmc dev" command is being called twice.
>
> Remove the extra call.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> include/configs/warp7.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/warp7.h b/include/configs/warp7.h
> index 9c6ee6997f..f1fc6c714f 100644
> --- a/include/configs/warp7.h
> +++ b/include/configs/warp7.h
> @@ -94,7 +94,6 @@
> "fi;\0" \
>
> #define CONFIG_BOOTCOMMAND \
> - "mmc dev ${mmcdev};" \
> "mmc dev ${mmcdev}; if mmc rescan; then " \
> "run do_bootscript_hab;" \
> "if run loadbootscript; then " \
>
Reviewed-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Tested-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Thanks !
--
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command
2019-10-23 14:20 ` [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command Fabio Estevam
2019-10-23 15:55 ` Pierre-Jean Texier
@ 2019-10-23 17:18 ` Joris Offouga
1 sibling, 0 replies; 6+ messages in thread
From: Joris Offouga @ 2019-10-23 17:18 UTC (permalink / raw)
To: u-boot
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
> The "mmc dev" command is being called twice.
>
> Remove the extra call.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> include/configs/warp7.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/warp7.h b/include/configs/warp7.h
> index 9c6ee6997f..f1fc6c714f 100644
> --- a/include/configs/warp7.h
> +++ b/include/configs/warp7.h
> @@ -94,7 +94,6 @@
> "fi;\0" \
>
> #define CONFIG_BOOTCOMMAND \
> - "mmc dev ${mmcdev};" \
> "mmc dev ${mmcdev}; if mmc rescan; then " \
> "run do_bootscript_hab;" \
> "if run loadbootscript; then " \
Reviewed-by: Joris Offouga <offougajoris@gmail.com>
Best regards,
Joris Offouga
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR
2019-10-23 14:20 [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR Fabio Estevam
2019-10-23 14:20 ` [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command Fabio Estevam
@ 2019-10-23 15:55 ` Pierre-Jean Texier
2019-10-23 17:49 ` Joris Offouga
2 siblings, 0 replies; 6+ messages in thread
From: Pierre-Jean Texier @ 2019-10-23 15:55 UTC (permalink / raw)
To: u-boot
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
> warp7 uses the driver model and it retrieves the ESDHC
> base address from device tree.
>
> Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> include/configs/warp7.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/warp7.h b/include/configs/warp7.h
> index 73541fe176..9c6ee6997f 100644
> --- a/include/configs/warp7.h
> +++ b/include/configs/warp7.h
> @@ -17,7 +17,6 @@
> #define CONFIG_SYS_MALLOC_LEN (35 * SZ_1M)
>
> /* MMC Config*/
> -#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
> #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
>
>
Reviewed-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Tested-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Thanks !
--
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR
2019-10-23 14:20 [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR Fabio Estevam
2019-10-23 14:20 ` [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command Fabio Estevam
2019-10-23 15:55 ` [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR Pierre-Jean Texier
@ 2019-10-23 17:49 ` Joris Offouga
2 siblings, 0 replies; 6+ messages in thread
From: Joris Offouga @ 2019-10-23 17:49 UTC (permalink / raw)
To: u-boot
Hi Fabio,
Le 23/10/2019 à 16:20, Fabio Estevam a écrit :
> warp7 uses the driver model and it retrieves the ESDHC
> base address from device tree.
>
> Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> include/configs/warp7.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/warp7.h b/include/configs/warp7.h
> index 73541fe176..9c6ee6997f 100644
> --- a/include/configs/warp7.h
> +++ b/include/configs/warp7.h
> @@ -17,7 +17,6 @@
> #define CONFIG_SYS_MALLOC_LEN (35 * SZ_1M)
>
> /* MMC Config*/
> -#define CONFIG_SYS_FSL_ESDHC_ADDR USDHC3_BASE_ADDR
> #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
>
Reviewed-by: Joris Offouga <offougajoris@gmail.com>
Tested-by: Joris Offouga <offougajoris@gmail.com>
Best regards,
Joris Offouga
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-23 17:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-23 14:20 [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR Fabio Estevam
2019-10-23 14:20 ` [U-Boot] [PATCH 2/2] warp7: Remove duplicate "mmc dev" command Fabio Estevam
2019-10-23 15:55 ` Pierre-Jean Texier
2019-10-23 17:18 ` Joris Offouga
2019-10-23 15:55 ` [U-Boot] [PATCH 1/2] warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR Pierre-Jean Texier
2019-10-23 17:49 ` Joris Offouga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox