[U-Boot] [PATCH] ARM: dts: da850-lcdk: Update DTS files for SPL device tree support

[U-Boot] [PATCH] ARM: dts: da850-lcdk: Update DTS files for SPL device tree support

[Adam Ford]

Currently, the da850-lcdk uses SPL_OF_PLATDATA and manually loads
the necessary source code instead of using the auto-generated,
because the drivers don't properly autogenerate the code.

This patch simply enables the various device tree options to
mimic the da850-evm which doesn't need or use OF_PLATDATA for
device tree support.  It does not disable OF_PLATDATA.

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/arch/arm/dts/da850-lcdk-u-boot.dtsi b/arch/arm/dts/da850-lcdk-u-boot.dtsi
index 541f4ca200..b372d06ca9 100644
--- a/arch/arm/dts/da850-lcdk-u-boot.dtsi
+++ b/arch/arm/dts/da850-lcdk-u-boot.dtsi
@@ -8,9 +8,23 @@
 / {
 	aliases {
 		i2c0 = &i2c0;
+		mmc0 = &mmc0;
+		serial2 = &serial2;
+	};
+
+	soc at 1c00000 {
+		u-boot,dm-spl;
 	};
 
 	nand {
 		compatible = "ti,davinci-nand";
 	};
 };
+
+&mmc0 {
+	u-boot,dm-spl;
+};
+
+&serial2 {
+	u-boot,dm-spl;
+};
diff --git a/arch/arm/dts/da850-lcdk.dts b/arch/arm/dts/da850-lcdk.dts
index 0177e3ed20..db8ae566f3 100644
--- a/arch/arm/dts/da850-lcdk.dts
+++ b/arch/arm/dts/da850-lcdk.dts
@@ -18,7 +18,7 @@
 	};
 
 	chosen {
-		stdout-path = "serial2:115200n8";
+		stdout-path = &serial2;
 	};
 
 	memory at c0000000 {
-- 
2.20.1

[U-Boot] [PATCH] ARM: dts: da850-lcdk: Update DTS files for SPL device tree support

[Bartosz Golaszewski]

śr., 13 lis 2019 o 16:46 Adam Ford <aford173@gmail.com> napisał(a):
>
> Currently, the da850-lcdk uses SPL_OF_PLATDATA and manually loads
> the necessary source code instead of using the auto-generated,
> because the drivers don't properly autogenerate the code.
>
> This patch simply enables the various device tree options to
> mimic the da850-evm which doesn't need or use OF_PLATDATA for
> device tree support.  It does not disable OF_PLATDATA.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm/dts/da850-lcdk-u-boot.dtsi b/arch/arm/dts/da850-lcdk-u-boot.dtsi
> index 541f4ca200..b372d06ca9 100644
> --- a/arch/arm/dts/da850-lcdk-u-boot.dtsi
> +++ b/arch/arm/dts/da850-lcdk-u-boot.dtsi
> @@ -8,9 +8,23 @@
>  / {
>         aliases {
>                 i2c0 = &i2c0;
> +               mmc0 = &mmc0;
> +               serial2 = &serial2;
> +       };
> +
> +       soc at 1c00000 {
> +               u-boot,dm-spl;
>         };
>
>         nand {
>                 compatible = "ti,davinci-nand";
>         };
>  };
> +
> +&mmc0 {
> +       u-boot,dm-spl;
> +};
> +
> +&serial2 {
> +       u-boot,dm-spl;
> +};
> diff --git a/arch/arm/dts/da850-lcdk.dts b/arch/arm/dts/da850-lcdk.dts
> index 0177e3ed20..db8ae566f3 100644
> --- a/arch/arm/dts/da850-lcdk.dts
> +++ b/arch/arm/dts/da850-lcdk.dts
> @@ -18,7 +18,7 @@
>         };
>
>         chosen {
> -               stdout-path = "serial2:115200n8";
> +               stdout-path = &serial2;
>         };
>
>         memory at c0000000 {
> --
> 2.20.1
>

Hi Adam,

the generated platdata has wrong driver names. I'm not sure how these
are generated but at first glance it looks like the compatible string
is transformed by converting commas and hyphens into underscores. This
of course won't work as the real driver names are different and the
lookup fails (with your patch - if I remove the serial U_BOOT_DEVICE()
from the board file, the serial stops working). Are you aware of how
other SPL users handle this?

Bart

[U-Boot] [PATCH] ARM: dts: da850-lcdk: Update DTS files for SPL device tree support

[Lokesh Vutla]

On 13/11/19 9:16 PM, Adam Ford wrote:
> Currently, the da850-lcdk uses SPL_OF_PLATDATA and manually loads
> the necessary source code instead of using the auto-generated,
> because the drivers don't properly autogenerate the code.
> 
> This patch simply enables the various device tree options to
> mimic the da850-evm which doesn't need or use OF_PLATDATA for
> device tree support.  It does not disable OF_PLATDATA.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Merged into u-boot-ti.

Thanks and regards,
Lokesh