From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/5] roc-rk3399-pc: Configure the leds only during POR
Date: Wed, 18 Mar 2020 15:14:02 +0530 [thread overview]
Message-ID: <20200318094405.25511-2-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20200318094405.25511-1-jagan@amarulasolutions.com>
ROC-RK3399-PC has specific set of configurations for
on-board led setup.
Due to easiness for user to know the state of the board
roc-rk339-pc board code will setup the led on/off, and
waiting for user to press power key.
All this needs to happen only during power-on-reset not
for soft reset or WDT. So add reset cause check to POR
and configure leds.
Reported-by: Markus Reichl <m.reichl@fivetechno.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
board/firefly/roc-pc-rk3399/roc-pc-rk3399.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c b/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c
index de9185a7ce..0a7d72a2a0 100644
--- a/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c
+++ b/board/firefly/roc-pc-rk3399/roc-pc-rk3399.c
@@ -33,11 +33,12 @@ out:
#endif
#if defined(CONFIG_TPL_BUILD)
+#include <asm/arch-rockchip/cru.h>
#define PMUGRF_BASE 0xff320000
#define GPIO0_BASE 0xff720000
-int board_early_init_f(void)
+void board_early_led_setup(void)
{
struct rockchip_gpio_regs * const gpio0 = (void *)GPIO0_BASE;
struct rk3399_pmugrf_regs * const pmugrf = (void *)PMUGRF_BASE;
@@ -55,7 +56,15 @@ int board_early_init_f(void)
spl_gpio_output(gpio0, GPIO(BANK_A, 2), 0);
spl_gpio_output(gpio0, GPIO(BANK_B, 5), 1);
+}
+
+int board_early_init_f(void)
+{
+ /* Set the leds only during POR */
+ if (!strcmp(get_reset_cause(), "POR"))
+ board_early_led_setup();
return 0;
}
+
#endif
--
2.17.1
next prev parent reply other threads:[~2020-03-18 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:44 [PATCH 1/5] rockchip: Separate the reset cause from display cpuinfo Jagan Teki
2020-03-18 9:44 ` Jagan Teki [this message]
2020-03-19 9:16 ` [2/5] roc-rk3399-pc: Configure the leds only during POR sunil at amarulasolutions.com
2020-03-18 9:44 ` [PATCH 3/5] rockchip: tpl: Move board_early_init_f after cpu timer Jagan Teki
2020-03-18 9:44 ` [PATCH 4/5] rockchip: tpl: Print TPL banner at end-of board_init_f Jagan Teki
2020-03-18 9:44 ` [PATCH 5/5] rockchip: spl: Move board_early_init_f after cpu timer Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318094405.25511-2-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox