From: Jagan Teki <jagan@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [PATCH 4/5] rockchip: tpl: Print TPL banner at end-of board_init_f
Date: Wed, 18 Mar 2020 15:14:04 +0530 [thread overview]
Message-ID: <20200318094405.25511-4-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20200318094405.25511-1-jagan@amarulasolutions.com>
Usually printing the TPL banner various between architecture
or board codes.
- Some of them would print at the end of board_init_f for
making sure all initialization prior to this would happen
properly. if at all there is a requirement for serial init,
that happen properly since it prints all after that.
- Some of them would print at the beginning once the debug
uart done. assuming this particular banner wouldn't require
any serial setup code.
Rockchip TPL is following later one and printing early in
board_init_f.
But, sometimes there is a use case where we can print the banner
only when the board_init_early_f done.
It is because board_init_early_f has gpio configuration required
for non-standard board design to glow the specific LEDs upon
user interaction. These board design wouldn't recommend to
print any console logs unless user interact with board via
some kind of power button.
This look specific to board but since all rockchip boards use
common tpl code, this seems to the desired solution. and also
it is following similar initialization as rockchip SPL like
- printing banner at end of board_init_f
- debug print at early board_init_f in debug_uart_init block.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
arch/arm/mach-rockchip/tpl.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-rockchip/tpl.c b/arch/arm/mach-rockchip/tpl.c
index fab85dff7d..a9eb27d788 100644
--- a/arch/arm/mach-rockchip/tpl.c
+++ b/arch/arm/mach-rockchip/tpl.c
@@ -60,10 +60,7 @@ void board_init_f(ulong dummy)
* printascii("string");
*/
debug_uart_init();
-#ifdef CONFIG_TPL_BANNER_PRINT
- printascii("\nU-Boot TPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \
- U_BOOT_TIME ")\n");
-#endif
+ debug("\ntpl:debug uart enabled in %s\n", __func__);
#endif
ret = spl_early_init();
if (ret) {
@@ -84,6 +81,11 @@ void board_init_f(ulong dummy)
printf("DRAM init failed: %d\n", ret);
return;
}
+
+#ifdef CONFIG_TPL_BANNER_PRINT
+ printascii("\nU-Boot TPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \
+ U_BOOT_TIME ")\n");
+#endif
}
int board_return_to_bootrom(struct spl_image_info *spl_image,
--
2.17.1
next prev parent reply other threads:[~2020-03-18 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:44 [PATCH 1/5] rockchip: Separate the reset cause from display cpuinfo Jagan Teki
2020-03-18 9:44 ` [PATCH 2/5] roc-rk3399-pc: Configure the leds only during POR Jagan Teki
2020-03-19 9:16 ` [2/5] " sunil at amarulasolutions.com
2020-03-18 9:44 ` [PATCH 3/5] rockchip: tpl: Move board_early_init_f after cpu timer Jagan Teki
2020-03-18 9:44 ` Jagan Teki [this message]
2020-03-18 9:44 ` [PATCH 5/5] rockchip: spl: " Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318094405.25511-4-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox