From: Ovidiu Panait <ovpanait@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] dm: dump.c: Fix segfault when entry->of_match is NULL
Date: Sun, 5 Apr 2020 19:47:40 +0300 [thread overview]
Message-ID: <20200405164741.11243-1-ovpanait@gmail.com> (raw)
Currently, dm drivers command produces a segfault:
=> dm drivers
Driver Compatible
--------------------------------
Segmentation fault (core dumped)
This is caused by a NULL pointer dereference of entry->of_match.
Add a check to prevent this.
Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>
Cc: Sean Anderson <seanga2@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
---
drivers/core/dump.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/core/dump.c b/drivers/core/dump.c
index e73ebeabcc..b5046398d4 100644
--- a/drivers/core/dump.c
+++ b/drivers/core/dump.c
@@ -107,7 +107,8 @@ void dm_dump_drivers(void)
puts("Driver Compatible\n");
puts("--------------------------------\n");
for (entry = d; entry < d + n_ents; entry++) {
- for (match = entry->of_match; match->compatible; match++)
+ for (match = entry->of_match;
+ match && match->compatible; match++)
printf("%-20.20s %s\n",
match == entry->of_match ? entry->name : "",
match->compatible);
--
2.17.1
next reply other threads:[~2020-04-05 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 16:47 Ovidiu Panait [this message]
2020-04-05 16:47 ` [PATCH 2/2] dm: dump.c: Refactor dm_dump_drivers prints Ovidiu Panait
2020-04-06 3:42 ` Simon Glass
2020-04-09 21:23 ` sjg at google.com
2020-04-05 16:53 ` [PATCH 1/2] dm: dump.c: Fix segfault when entry->of_match is NULL Sean Anderson
2020-04-05 17:08 ` Ovidiu Panait
2020-04-06 3:42 ` Simon Glass
2020-04-09 21:23 ` sjg at google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200405164741.11243-1-ovpanait@gmail.com \
--to=ovpanait@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox