From: Ovidiu Panait <ovpanait@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/2] dm: dump.c: Refactor dm_dump_drivers prints
Date: Sun, 5 Apr 2020 19:47:41 +0300 [thread overview]
Message-ID: <20200405164741.11243-2-ovpanait@gmail.com> (raw)
In-Reply-To: <20200405164741.11243-1-ovpanait@gmail.com>
Refactor the printing sequence in dm_dump_drivers to make it more clear.
Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>
Cc: Sean Anderson <seanga2@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
---
drivers/core/dump.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/core/dump.c b/drivers/core/dump.c
index b5046398d4..cb8a25b9ad 100644
--- a/drivers/core/dump.c
+++ b/drivers/core/dump.c
@@ -107,12 +107,16 @@ void dm_dump_drivers(void)
puts("Driver Compatible\n");
puts("--------------------------------\n");
for (entry = d; entry < d + n_ents; entry++) {
- for (match = entry->of_match;
- match && match->compatible; match++)
- printf("%-20.20s %s\n",
- match == entry->of_match ? entry->name : "",
- match->compatible);
- if (match == entry->of_match)
- printf("%-20.20s\n", entry->name);
+ match = entry->of_match;
+
+ printf("%-20.20s", entry->name);
+ if (match) {
+ printf(" %s", match->compatible);
+ match++;
+ }
+ printf("\n");
+
+ for (; match && match->compatible; match++)
+ printf("%-20.20s %s\n", "", match->compatible);
}
}
--
2.17.1
next prev parent reply other threads:[~2020-04-05 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 16:47 [PATCH 1/2] dm: dump.c: Fix segfault when entry->of_match is NULL Ovidiu Panait
2020-04-05 16:47 ` Ovidiu Panait [this message]
2020-04-06 3:42 ` [PATCH 2/2] dm: dump.c: Refactor dm_dump_drivers prints Simon Glass
2020-04-09 21:23 ` sjg at google.com
2020-04-05 16:53 ` [PATCH 1/2] dm: dump.c: Fix segfault when entry->of_match is NULL Sean Anderson
2020-04-05 17:08 ` Ovidiu Panait
2020-04-06 3:42 ` Simon Glass
2020-04-09 21:23 ` sjg at google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200405164741.11243-2-ovpanait@gmail.com \
--to=ovpanait@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox