From: Marek Behun <marek.behun@nic.cz>
To: u-boot@lists.denx.de
Subject: [PATCH v1 u-boot-marvell 4/5] arm64: mvebu: a37xx: add device-tree fixer for PCIe regions
Date: Thu, 9 Apr 2020 15:29:03 +0200 [thread overview]
Message-ID: <20200409152903.5273e404@nic.cz> (raw)
In-Reply-To: <b9e2a53c-801b-b3d1-5421-7ccb4258bac0@denx.de>
Hi Stefan,
sorry I overlooked the other two things you commented on the code.
On Thu, 9 Apr 2020 10:09:52 +0200
Stefan Roese <sr@denx.de> wrote:
> > + return -1;
>
> return -ENOENT; ?
The function returns u32. The error is reported by returning (u32)-1.
The check base < 0 won't work. I would specifically have to check for
-ENOENT, or use something like ERR_PTR from Linux.
> if (base < 0)
> return base; ?
next prev parent reply other threads:[~2020-04-09 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 17:25 [PATCH v1 u-boot-marvell 0/5] MVEBU ARM64 improvments + another Turris Mox patch Marek Behún
2020-04-08 17:25 ` [PATCH v1 u-boot-marvell 1/5] arm64: mvebu: armada-8k: move dram init code Marek Behún
2020-04-14 7:58 ` Stefan Roese
2020-04-08 17:25 ` [PATCH v1 u-boot-marvell 2/5] arm64: mvebu: a37xx: improve code determining memory info structures Marek Behún
2020-04-14 8:02 ` Stefan Roese
2020-04-08 17:25 ` [PATCH v1 u-boot-marvell 3/5] arm: mvebu: turris_mox: support devices with RAM > 1 GB Marek Behún
2020-04-14 8:03 ` Stefan Roese
2020-04-08 17:25 ` [PATCH v1 u-boot-marvell 4/5] arm64: mvebu: a37xx: add device-tree fixer for PCIe regions Marek Behún
2020-04-09 8:09 ` Stefan Roese
2020-04-09 13:17 ` Marek Behun
2020-04-09 13:29 ` Marek Behun [this message]
2020-04-14 8:03 ` Stefan Roese
2020-04-08 17:25 ` [PATCH v1 u-boot-marvell 5/5] arm: mvebu: turris_mox: fix PCIe ranges in device tree Marek Behún
2020-04-14 8:04 ` Stefan Roese
2020-04-14 8:06 ` [PATCH v1 u-boot-marvell 0/5] MVEBU ARM64 improvments + another Turris Mox patch Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409152903.5273e404@nic.cz \
--to=marek.behun@nic.cz \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox