From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 6/7] ddr: altera: arria10: Change %i to %u for printf
Date: Wed, 15 Apr 2020 10:56:47 -0400 [thread overview]
Message-ID: <20200415145647.GA12111@bill-the-cat> (raw)
In-Reply-To: <8f4b3545-c159-dd24-ed26-8e0b47c759e8@denx.de>
On Wed, Apr 15, 2020 at 02:45:08PM +0200, Marek Vasut wrote:
> On 4/15/20 11:00 AM, Ley Foon Tan wrote:
> > Tiny printf doesn't support %i, change to %u.
> >
> > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> > ---
> > drivers/ddr/altera/sdram_arria10.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ddr/altera/sdram_arria10.c b/drivers/ddr/altera/sdram_arria10.c
> > index e3f11984a978..8acf324117af 100644
> > --- a/drivers/ddr/altera/sdram_arria10.c
> > +++ b/drivers/ddr/altera/sdram_arria10.c
> > @@ -195,7 +195,7 @@ static void sdram_init_ecc_bits(u32 size)
> >
> > dcache_enable();
> >
> > - printf("DDRCAL: Scrubbing ECC RAM (%i MiB).\n", size >> 20);
> > + printf("DDRCAL: Scrubbing ECC RAM (%u MiB).\n", size >> 20);
> > memset((void *)0x8000, 0, size - 0x8000);
> > flush_dcache_all();
> > printf("DDRCAL: Scrubbing ECC RAM done.\n");
>
> Yes, sadly, tiny printf is broken so we need to patch code to work
> around that breakage.
Yes, limited by design, thanks for changing.
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200415/574b3cf1/attachment.sig>
next prev parent reply other threads:[~2020-04-15 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 9:00 [PATCH 0/7] ddr: altera: arria10: Convert SDRAM driver to DM Ley Foon Tan
2020-04-15 9:00 ` [PATCH 1/7] ddr: altera: arria10: Fix incorrect address for mpu1 Ley Foon Tan
2020-04-15 12:37 ` Marek Vasut
2020-04-16 1:23 ` Tan, Ley Foon
2020-04-15 9:00 ` [PATCH 2/7] ddr: altera: arria10: Move SDRAM driver to DM Ley Foon Tan
2020-04-15 12:42 ` Marek Vasut
2020-04-16 1:41 ` Tan, Ley Foon
2020-04-16 8:51 ` Marek Vasut
2020-04-15 9:00 ` [PATCH 3/7] ddr: altera: arria10: Change to use reset DM function Ley Foon Tan
2020-04-15 12:43 ` Marek Vasut
2020-04-16 1:42 ` Tan, Ley Foon
2020-04-15 9:00 ` [PATCH 4/7] arm: socfpga: arria10: Move sdram_arria10.h to drivers/ddr/altera Ley Foon Tan
2020-04-15 9:00 ` [PATCH 5/7] ddr: altera: arria10: Add RAM size check Ley Foon Tan
2020-04-15 12:44 ` Marek Vasut
2020-04-16 1:34 ` Tan, Ley Foon
2020-04-16 8:52 ` Marek Vasut
2020-04-16 9:18 ` Tan, Ley Foon
2020-04-15 9:00 ` [PATCH 6/7] ddr: altera: arria10: Change %i to %u for printf Ley Foon Tan
2020-04-15 12:45 ` Marek Vasut
2020-04-15 14:56 ` Tom Rini [this message]
2020-04-15 14:58 ` Marek Vasut
2020-04-15 15:14 ` Tom Rini
2020-04-15 15:16 ` Marek Vasut
2020-04-15 17:44 ` Tom Rini
2020-04-15 18:06 ` Marek Vasut
2020-04-16 12:55 ` Tom Rini
2020-04-16 13:11 ` Marek Vasut
2020-04-16 13:21 ` Tom Rini
2020-04-16 13:39 ` Marek Vasut
2020-04-16 18:02 ` Tom Rini
2020-04-16 19:33 ` Marek Vasut
2020-04-15 9:00 ` [PATCH 7/7] ddr: altera: arria10: Remove call to dram_init_banksize() Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415145647.GA12111@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox