From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] env: make file-scope env_ptr variables static
Date: Tue, 21 Apr 2020 08:25:40 -0400 [thread overview]
Message-ID: <20200421122540.GS4555@bill-the-cat> (raw)
In-Reply-To: <20200218085356.13929-1-rasmus.villemoes@prevas.dk>
On Tue, Feb 18, 2020 at 08:54:09AM +0000, Rasmus Villemoes wrote:
> The combination ENV_IS_IN_NVRAM=y, ENV_IS_IN_REMOTE=y fails to build:
>
> env/remote.o:/mnt/ext4/devel/u-boot/env/remote.c:17: multiple definition of `env_ptr'
> env/nvram.o:/mnt/ext4/devel/u-boot/env/nvram.c:41: first defined here
>
> It's not necessarily a meaningful combination, but for build-testing
> it's nice to be able to enable most ENV_IS_IN_* at the same time, and
> since these env_ptr are not declared anywhere, they really have no
> reason to have external linkage.
>
> nand.c and flash.c similarly already define file-scope static env_ptr
> variables.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200421/d360ad0d/attachment.sig>
prev parent reply other threads:[~2020-04-21 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 8:54 [PATCH] env: make file-scope env_ptr variables static Rasmus Villemoes
2020-04-21 12:25 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421122540.GS4555@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox