From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/3] log: Allow LOG_DEBUG to always enable log output
Date: Fri, 15 May 2020 14:47:21 -0400 [thread overview]
Message-ID: <20200515184721.GA6647@bill-the-cat> (raw)
In-Reply-To: <20200506140357.32050-1-sjg@chromium.org>
On Wed, May 06, 2020 at 08:03:55AM -0600, Simon Glass wrote:
> At present if CONFIG_LOG enabled, putting LOG_DEBUG at the top of a file
> (before log.h inclusion) causes _log() to be executed for every log()
> call, regardless of the build- or run-time logging level.
>
> However there is no guarantee that the log record will actually be
> displayed. If the current log level is lower than LOGL_DEBUG then it will
> not be.
>
> Add a way to signal that the log record should always be displayed and
> update log_passes_filters() to handle this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> common/log.c | 6 +++++-
> doc/README.log | 7 ++-----
> include/log.h | 16 ++++++++++++----
> 3 files changed, 19 insertions(+), 10 deletions(-)
Two levels of problems with (I believe) this patch:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/94674 fails a unit test now
around logging.
https://gitlab.denx.de/u-boot/u-boot/-/jobs/94671 shows a ton of new
warnings with clang.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200515/8bdd46a5/attachment.sig>
prev parent reply other threads:[~2020-05-15 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 14:03 [PATCH 1/3] log: Allow LOG_DEBUG to always enable log output Simon Glass
2020-05-06 14:03 ` [PATCH 2/3] lib: Allow MD5 to be enabled in SPL Simon Glass
2020-05-15 20:53 ` Tom Rini
2020-05-06 14:03 ` [PATCH 3/3] lib: Allow hexdump to be used " Simon Glass
2020-05-06 15:11 ` Stefan Roese
2020-05-15 18:17 ` Tom Rini
2020-05-15 18:47 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515184721.GA6647@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox