public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 09/12] led: gpio: Default to using node name if label is absent
Date: Wed, 24 Jun 2020 06:29:44 -0400	[thread overview]
Message-ID: <20200624102947.359794-10-seanga2@gmail.com> (raw)
In-Reply-To: <20200624102947.359794-1-seanga2@gmail.com>

This more closely mirrors Linux's behaviour, and will make it easier to
transition to using function+color in the future.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
This patch was previously submitted as part of
https://patchwork.ozlabs.org/project/uboot/list/?series=161576

(no changes since v1)

 drivers/led/led_gpio.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c
index ef9b61ee62..2cdb0269f4 100644
--- a/drivers/led/led_gpio.c
+++ b/drivers/led/led_gpio.c
@@ -99,11 +99,8 @@ static int led_gpio_bind(struct udevice *parent)
 		const char *label;
 
 		label = ofnode_read_string(node, "label");
-		if (!label) {
-			debug("%s: node %s has no label\n", __func__,
-			      ofnode_get_name(node));
-			return -EINVAL;
-		}
+		if (!label)
+			label = ofnode_get_name(node);
 		ret = device_bind_driver_to_node(parent, "gpio_led",
 						 ofnode_get_name(node),
 						 node, &dev);
-- 
2.26.2

  parent reply	other threads:[~2020-06-24 10:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24 10:29 [PATCH v4 00/12] riscv: Add FPIOA and GPIO support for Kendryte K210 Sean Anderson
2020-06-24 10:29 ` [PATCH v4 01/12] pinctrl: Add pinmux property support to pinctrl-generic Sean Anderson
2020-06-24 10:29 ` [PATCH v4 02/12] pinctrl: Reformat documentation in dm/pinctrl.h Sean Anderson
2020-07-03  0:46   ` Simon Glass
2020-06-24 10:29 ` [PATCH v4 03/12] test: pinmux: Add test for pin muxing Sean Anderson
2020-07-03  0:46   ` Simon Glass
2020-06-24 10:29 ` [PATCH v4 04/12] pinctrl: Add support for Kendryte K210 FPIOA Sean Anderson
2020-07-03  0:46   ` Simon Glass
2020-06-24 10:29 ` [PATCH v4 05/12] gpio: sifive: Use generic reg read function Sean Anderson
2020-07-03  0:46   ` Simon Glass
2020-06-24 10:29 ` [PATCH v4 06/12] gpio: dw: Fix warnings about casting int to pointer Sean Anderson
2020-06-24 10:29 ` [PATCH v4 07/12] gpio: dw: Add a trailing underscore to generated name Sean Anderson
2020-07-03  0:46   ` Simon Glass
2020-06-24 10:29 ` [PATCH v4 08/12] gpio: dw: Return output value when direction is out Sean Anderson
2020-06-24 10:29 ` Sean Anderson [this message]
2020-06-24 10:29 ` [PATCH v4 10/12] test: dm: Test for default led naming Sean Anderson
2020-07-03  0:46   ` Simon Glass
2020-06-24 10:29 ` [PATCH v4 11/12] riscv: Add pinmux and gpio bindings for Kendryte K210 Sean Anderson
2020-07-03  0:46   ` Simon Glass
2020-06-24 10:29 ` [PATCH v4 12/12] riscv: Add FPIOA and GPIO support " Sean Anderson
2020-08-12 14:03 ` [PATCH v4 00/12] " Sean Anderson
2020-08-14  0:37   ` Rick Chen
2020-08-14  1:52     ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624102947.359794-10-seanga2@gmail.com \
    --to=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox