From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] usb: gadget: ether: Fix warnings about unused code
Date: Tue, 25 Aug 2020 08:50:02 -0400 [thread overview]
Message-ID: <20200825125002.GK20605@bill-the-cat> (raw)
In-Reply-To: <20200825115517.6feb9de4@jawa>
On Tue, Aug 25, 2020 at 11:55:17AM +0200, Lukasz Majewski wrote:
> Hi Tom,
>
> > When building this with clang we see a few new warnings. There are a
> > handful of structs that we declare and use only in the case of
> > !defined(CONFIG_USB_ETH_CDC) && defined(CONFIG_USB_ETH_SUBSET) so
> > update the guards used to match this as well as cover all members
> > rather than just a few. Finally, eth_is_promisc() is only called by
> > eth_start_xmit() which is under and #if 0 and immediately follows the
> > function. Move the #if 0 up.
> >
>
> Could you double check this patch and rebase it on top of newest master.
>
> As it is now it causes following build break:
> https://travis-ci.org/github/lmajewski/u-boot-dfu/jobs/720654040
Lets just set it aside then. It was fine at the time but I've put down
my experiment of building various targets with clang for now.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200825/3b6959fe/attachment.sig>
prev parent reply other threads:[~2020-08-25 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 20:08 [PATCH] usb: gadget: ether: Fix warnings about unused code Tom Rini
2020-08-25 9:55 ` Lukasz Majewski
2020-08-25 12:50 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825125002.GK20605@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox