From: Eugen Hristev <eugen.hristev@microchip.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 4/6] mmc: atmel-sdhci: do not check clk_set_rate return value
Date: Thu, 27 Aug 2020 12:25:55 +0300 [thread overview]
Message-ID: <20200827092557.269129-1-eugen.hristev@microchip.com> (raw)
clk_set_rate will return rate in case of success and zero in case of
error, however it can also return -ev, but it's an ulong function.
To avoid any issues, disregard the return value of this call.
In case this call actually fails, nothing much we can do anyway, but we
can at least try with the previous values (or DT assigned-clocks)
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
drivers/mmc/atmel_sdhci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/atmel_sdhci.c b/drivers/mmc/atmel_sdhci.c
index f03c0457e1..54b660c34a 100644
--- a/drivers/mmc/atmel_sdhci.c
+++ b/drivers/mmc/atmel_sdhci.c
@@ -79,9 +79,7 @@ static int atmel_sdhci_probe(struct udevice *dev)
if (ret)
return ret;
- ret = clk_set_rate(&clk, ATMEL_SDHC_GCK_RATE);
- if (ret)
- return ret;
+ clk_set_rate(&clk, ATMEL_SDHC_GCK_RATE);
max_clk = clk_get_rate(&clk);
if (!max_clk)
--
2.25.1
next reply other threads:[~2020-08-27 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 9:25 Eugen Hristev [this message]
2020-08-27 9:25 ` [PATCH v2 5/6] mmc: atmel-sdhci: enable the required generic clock Eugen Hristev
2020-08-28 5:36 ` Peng Fan
2020-08-27 9:25 ` [PATCH v2 6/6] mmc: atmel-sdhci: use mmc_of_parse to get the DT properties Eugen Hristev
2020-08-27 9:32 ` Peng Fan
-- strict thread matches above, loose matches on Subject: below --
2020-08-27 9:16 [PATCH v2 4/6] mmc: atmel-sdhci: do not check clk_set_rate return value Eugen Hristev
2020-08-28 5:37 ` Peng Fan
2020-09-07 9:42 ` Eugen.Hristev at microchip.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827092557.269129-1-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox