public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Behun <marek.behun@nic.cz>
To: u-boot@lists.denx.de
Subject: [PATCH u-boot-marvell] arm64: dts: armada-3720-espressobin: fix COMPHY nodes
Date: Mon, 31 Aug 2020 00:57:34 +0200	[thread overview]
Message-ID: <20200831005734.2893a86a@nic.cz> (raw)
In-Reply-To: <24abb511-b3eb-f2c9-0306-bd5c88bd4b53@gmail.com>

On Sun, 30 Aug 2020 08:38:32 +0200
Andre Heider <a.heider@gmail.com> wrote:

> Hi Marek,
> 
> On 19/08/2020 11:57, Marek Beh?n wrote:
> > This commit fixes initialization of COMPHY on EspressoBin.
> > 
> > Commit 22f418935be4 ("phy: marvell: a3700: Use comphy_mux on Armada
> > 37xx.") introduced usage of comphy_mux on Armada 37xx comphy driver.
> > The lanes are defined in comphy_a3700.c as described in functional
> > specification, that is:
> >    lane 0 is SGMII1 or USB3
> >    lane 1 is PCIe or SGMII0
> >    lane 2 is SATA or USB3
> > 
> > But the DTS for EspressoBin configures PCIe on lane 0 and USB3 on
> > lane 1, which is wrong in the sense of the specification and doesn't
> > work with the comphy_mux code, which is 2 years now (the aardvark driver
> > causes synchronous abort in U-Boot).  
> 
> I think armada-3720-db.dts requires the same fix?
> 
> Regards,
> Andre

You are right. Sigh :( ....

  reply	other threads:[~2020-08-30 22:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  9:57 [PATCH u-boot-marvell] arm64: dts: armada-3720-espressobin: fix COMPHY nodes Marek Behún
2020-08-19 10:10 ` [EXT] " Kostya Porotchkin
2020-08-19 10:33 ` Stefan Roese
2020-08-26  7:12 ` Andre Heider
2020-08-28  8:18 ` Andre Heider
2020-08-28 14:59   ` Andre Heider
2020-08-30  6:38 ` Andre Heider
2020-08-30 22:57   ` Marek Behun [this message]
2020-08-31 13:02 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831005734.2893a86a@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox