* [PATCH v3] x86: qemu: Remove dead code
@ 2020-09-01 8:33 Andy Shevchenko
2020-09-01 9:02 ` Bin Meng
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2020-09-01 8:33 UTC (permalink / raw)
To: u-boot
start.S does nothing and can be safely removed. Makefile is still being used
by the build system, so simply replace the rule in it. We use stub C-file
like it's done for other boards.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
v3: fixed linker error (Bin)
board/emulation/qemu-x86/Makefile | 2 +-
board/emulation/qemu-x86/qemu-x86.c | 0
board/emulation/qemu-x86/start.S | 8 --------
3 files changed, 1 insertion(+), 9 deletions(-)
create mode 100644 board/emulation/qemu-x86/qemu-x86.c
delete mode 100644 board/emulation/qemu-x86/start.S
diff --git a/board/emulation/qemu-x86/Makefile b/board/emulation/qemu-x86/Makefile
index 782e298b74ce..ff4aaa51c540 100644
--- a/board/emulation/qemu-x86/Makefile
+++ b/board/emulation/qemu-x86/Makefile
@@ -2,4 +2,4 @@
#
# Copyright (C) 2015, Bin Meng <bmeng.cn@gmail.com>
-obj-y += start.o
+obj-y += qemu-x86.o
diff --git a/board/emulation/qemu-x86/qemu-x86.c b/board/emulation/qemu-x86/qemu-x86.c
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/board/emulation/qemu-x86/start.S b/board/emulation/qemu-x86/start.S
deleted file mode 100644
index e4bde561b20d..000000000000
--- a/board/emulation/qemu-x86/start.S
+++ /dev/null
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Bin Meng <bmeng.cn@gmail.com>
- */
-
-.globl early_board_init
-early_board_init:
- jmp early_board_init_ret
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v3] x86: qemu: Remove dead code
2020-09-01 8:33 [PATCH v3] x86: qemu: Remove dead code Andy Shevchenko
@ 2020-09-01 9:02 ` Bin Meng
0 siblings, 0 replies; 2+ messages in thread
From: Bin Meng @ 2020-09-01 9:02 UTC (permalink / raw)
To: u-boot
On Tue, Sep 1, 2020 at 4:33 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> start.S does nothing and can be safely removed. Makefile is still being used
> by the build system, so simply replace the rule in it. We use stub C-file
> like it's done for other boards.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> v3: fixed linker error (Bin)
> board/emulation/qemu-x86/Makefile | 2 +-
> board/emulation/qemu-x86/qemu-x86.c | 0
> board/emulation/qemu-x86/start.S | 8 --------
> 3 files changed, 1 insertion(+), 9 deletions(-)
> create mode 100644 board/emulation/qemu-x86/qemu-x86.c
> delete mode 100644 board/emulation/qemu-x86/start.S
>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-01 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-01 8:33 [PATCH v3] x86: qemu: Remove dead code Andy Shevchenko
2020-09-01 9:02 ` Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox