From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1] cmd: acpi: Print revisions in hex format
Date: Tue, 8 Sep 2020 18:48:38 +0300 [thread overview]
Message-ID: <20200908154838.GF1891694@smile.fi.intel.com> (raw)
In-Reply-To: <OF3B499DC7.ECB9EEFF-ONC12585DD.0054A48C-C12585DD.005556F9@br-automation.com>
On Tue, Sep 08, 2020 at 05:32:08PM +0200, Wolfgang Wallner wrote:
> -----"Andy Shevchenko" <andy.shevchenko@gmail.com> schrieb: -----
> > On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
> > <wolfgang.wallner@br-automation.com> wrote:
> > > -----"Andy Shevchenko" <andriy.shevchenko@linux.intel.com> schrieb: -----
...
> > > Related to "acpi list":
> > > During my recent ACPI debugging I found it very useful to have the checksum
> > > printed for each table with "acpi list". Would there be interest to have that
> > > upstream? If so I would send a patch.
> >
> > Can you elaborate what was the problem that checksum helped?
>
> Sure. I saw two strange things with the ACPI checksums:
>
> 1) The DSDT length included uninitialized bytes from alignment. This is
> described in the following link:
>
> https://lists.denx.de/pipermail/u-boot/2020-September/425378.html
>
> This was the actual bug I was looking for.
>
> 2) acpi_create_spcr() is missing a memset(). The other acpi_create_xxxx()
> functions perform a memset on their structure, acpi_create_spcr() does not
> and as a result the contents of this table are party uninitialized.
>
> I plan to send a patch for both of them.
I'm not sure I understood how checksum pointed to uninitialized data?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-08 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 14:30 [PATCH v1] cmd: acpi: Print revisions in hex format Andy Shevchenko
2020-09-08 14:58 ` Wolfgang Wallner
2020-09-08 15:17 ` Andy Shevchenko
2020-09-08 15:32 ` Wolfgang Wallner
2020-09-08 15:48 ` Andy Shevchenko [this message]
2020-09-09 7:15 ` Wolfgang Wallner
2020-09-09 8:51 ` Andy Shevchenko
2020-09-21 1:31 ` Bin Meng
2020-09-21 1:35 ` Bin Meng
2020-09-21 2:20 ` Bin Meng
2020-09-21 8:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908154838.GF1891694@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox