From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1] cmd: acpi: Print revisions in hex format
Date: Mon, 21 Sep 2020 11:36:04 +0300 [thread overview]
Message-ID: <20200921083604.GO3956970@smile.fi.intel.com> (raw)
In-Reply-To: <CAEUhbmVMsD-jLY4KEOB96K0sQ_P0R8wD4WHyK0o48RbZJEbZAQ@mail.gmail.com>
On Mon, Sep 21, 2020 at 10:20:18AM +0800, Bin Meng wrote:
> On Tue, Sep 8, 2020 at 10:30 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The revisions are usually dates in hex-decimal format representing
> > YYYYmmdd. Print them in hex to see this clearly.
> >
> > Before:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 538970376 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 65536 INTL 538968870)
> > ...
> > After:
> > ...
> > FACP 000e5420 0000f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
> > DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 10000 INTL 20200326)
> > ...
> >
> > Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> > Cc: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > cmd/acpi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/cmd/acpi.c b/cmd/acpi.c
> > index 085a3a650d1a..a3419b42b556 100644
> > --- a/cmd/acpi.c
> > +++ b/cmd/acpi.c
> > @@ -26,7 +26,7 @@ static void dump_hdr(struct acpi_table_header *hdr)
> > printf("%.*s %08lx %06x", ACPI_NAME_LEN, hdr->signature,
> > (ulong)map_to_sysmem(hdr), hdr->length);
> > if (has_hdr) {
> > - printf(" (v%02d %.6s %.8s %u %.4s %d)\n", hdr->revision,
> > + printf(" (v%02d %.6s %.8s %x %.4s %x)\n", hdr->revision,
> > hdr->oem_id, hdr->oem_table_id, hdr->oem_revision,
> > hdr->aslc_id, hdr->aslc_revision);
> > } else {
> > --
>
> This unfortunately breaks the unit test.
>
> /u/test/dm/acpi.c:371, dm_test_acpi_cmd_list(): console:
> Expected 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 538970401 INTL 0)',
> got 'RSDT 0570ebf0 000030 (v01 U-BOOT U-BOOTBL 20200921 INTL 0)'
> Failures: 2
>
> Would you please resend v2 to fix this?
v2 has been just sent. Thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-09-21 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 14:30 [PATCH v1] cmd: acpi: Print revisions in hex format Andy Shevchenko
2020-09-08 14:58 ` Wolfgang Wallner
2020-09-08 15:17 ` Andy Shevchenko
2020-09-08 15:32 ` Wolfgang Wallner
2020-09-08 15:48 ` Andy Shevchenko
2020-09-09 7:15 ` Wolfgang Wallner
2020-09-09 8:51 ` Andy Shevchenko
2020-09-21 1:31 ` Bin Meng
2020-09-21 1:35 ` Bin Meng
2020-09-21 2:20 ` Bin Meng
2020-09-21 8:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921083604.GO3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox