* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
@ 2021-01-02 16:44 Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Marek Vasut @ 2021-01-02 16:44 UTC (permalink / raw)
To: u-boot
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
using output-low DT property leads to the GPIO being set high instead.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
---
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
index 7f5cff49b70..59d13713d88 100644
--- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
+++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
@@ -37,7 +37,7 @@
*/
usb-port-power {
gpio-hog;
- gpios = <13 GPIO_ACTIVE_LOW>;
+ gpios = <13 0>;
output-low;
line-name = "usb-port-power";
};
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
@ 2021-01-02 16:44 ` Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
2021-01-05 13:55 ` [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2021-01-02 16:44 UTC (permalink / raw)
To: u-boot
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the
correctness of the DT.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
---
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
index e8508aa4d5a..4948ccd4014 100644
--- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
+++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
@@ -37,7 +37,7 @@
*/
usb-hub {
gpio-hog;
- gpios = <8 GPIO_ACTIVE_HIGH>;
+ gpios = <8 0>;
output-high;
line-name = "rs485-rx-en";
};
@@ -65,7 +65,7 @@
*/
usb-hub {
gpio-hog;
- gpios = <2 GPIO_ACTIVE_HIGH>;
+ gpios = <2 0>;
output-high;
line-name = "usb-hub-reset";
};
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
@ 2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
1 sibling, 0 replies; 7+ messages in thread
From: Patrice CHOTARD @ 2021-01-05 16:39 UTC (permalink / raw)
To: u-boot
Hi Marek
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the
> correctness of the DT.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> index e8508aa4d5a..4948ccd4014 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> @@ -37,7 +37,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <8 GPIO_ACTIVE_HIGH>;
> + gpios = <8 0>;
> output-high;
> line-name = "rs485-rx-en";
> };
> @@ -65,7 +65,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <2 GPIO_ACTIVE_HIGH>;
> + gpios = <2 0>;
> output-high;
> line-name = "usb-hub-reset";
> };
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
@ 2021-01-06 9:05 ` Patrick DELAUNAY
1 sibling, 0 replies; 7+ messages in thread
From: Patrick DELAUNAY @ 2021-01-06 9:05 UTC (permalink / raw)
To: u-boot
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the
> correctness of the DT.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> index e8508aa4d5a..4948ccd4014 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-drc02.dts
> @@ -37,7 +37,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <8 GPIO_ACTIVE_HIGH>;
> + gpios = <8 0>;
> output-high;
> line-name = "rs485-rx-en";
> };
> @@ -65,7 +65,7 @@
> */
> usb-hub {
> gpio-hog;
> - gpios = <2 GPIO_ACTIVE_HIGH>;
> + gpios = <2 0>;
> output-high;
> line-name = "usb-hub-reset";
> };
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
@ 2021-01-05 13:55 ` Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
3 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2021-01-05 13:55 UTC (permalink / raw)
To: u-boot
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
+CC Tom
These two should be applied to 2021.01 as well, can you pick them ?
Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
2021-01-05 13:55 ` [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
@ 2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
3 siblings, 0 replies; 7+ messages in thread
From: Patrice CHOTARD @ 2021-01-05 16:39 UTC (permalink / raw)
To: u-boot
Hi Marek
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> index 7f5cff49b70..59d13713d88 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> @@ -37,7 +37,7 @@
> */
> usb-port-power {
> gpio-hog;
> - gpios = <13 GPIO_ACTIVE_LOW>;
> + gpios = <13 0>;
> output-low;
> line-name = "usb-port-power";
> };
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
` (2 preceding siblings ...)
2021-01-05 16:39 ` Patrice CHOTARD
@ 2021-01-06 9:05 ` Patrick DELAUNAY
3 siblings, 0 replies; 7+ messages in thread
From: Patrick DELAUNAY @ 2021-01-06 9:05 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 1/2/21 5:44 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> index 7f5cff49b70..59d13713d88 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> +++ b/arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts
> @@ -37,7 +37,7 @@
> */
> usb-port-power {
> gpio-hog;
> - gpios = <13 GPIO_ACTIVE_LOW>;
> + gpios = <13 0>;
> output-low;
> line-name = "usb-port-power";
> };
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-06 9:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-02 16:44 [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-02 16:44 ` [PATCH 2/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02 Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
2021-01-05 13:55 ` [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX Marek Vasut
2021-01-05 16:39 ` Patrice CHOTARD
2021-01-06 9:05 ` Patrick DELAUNAY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox