* [PATCH] net: eth-uclass: Change uclass driver name to ethernet
@ 2021-01-07 3:55 David Wu
2021-01-07 12:36 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: David Wu @ 2021-01-07 3:55 UTC (permalink / raw)
To: u-boot
dev_read_alias_seq() used uc_drv->name compared to alias
stem string, Ethernet's alias stem uses "ethernet", which
does not match the eth-uclass driver name "eth", can not
get the correct index of ethernet alias namer. So it seems
change uclass driver name to match the alias stem is a more
reasonable way.
Signed-off-by: David Wu <david.wu@rock-chips.com>
---
net/eth-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index e14695c0f1..7dd962db64 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -594,7 +594,7 @@ static int eth_pre_remove(struct udevice *dev)
}
UCLASS_DRIVER(eth) = {
- .name = "eth",
+ .name = "ethernet",
.id = UCLASS_ETH,
.post_bind = eth_post_bind,
.pre_unbind = eth_pre_unbind,
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] net: eth-uclass: Change uclass driver name to ethernet
2021-01-07 3:55 [PATCH] net: eth-uclass: Change uclass driver name to ethernet David Wu
@ 2021-01-07 12:36 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2021-01-07 12:36 UTC (permalink / raw)
To: u-boot
Hi David,
On Wed, 6 Jan 2021 at 20:56, David Wu <david.wu@rock-chips.com> wrote:
>
> dev_read_alias_seq() used uc_drv->name compared to alias
> stem string, Ethernet's alias stem uses "ethernet", which
> does not match the eth-uclass driver name "eth", can not
> get the correct index of ethernet alias namer. So it seems
> change uclass driver name to match the alias stem is a more
> reasonable way.
>
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> ---
> net/eth-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/eth-uclass.c b/net/eth-uclass.c
> index e14695c0f1..7dd962db64 100644
> --- a/net/eth-uclass.c
> +++ b/net/eth-uclass.c
> @@ -594,7 +594,7 @@ static int eth_pre_remove(struct udevice *dev)
> }
>
> UCLASS_DRIVER(eth) = {
Should change this one too ^
> - .name = "eth",
> + .name = "ethernet",
> .id = UCLASS_ETH,
> .post_bind = eth_post_bind,
> .pre_unbind = eth_pre_unbind,
> --
> 2.19.1
>
>
Regards,
Simon
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-07 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-07 3:55 [PATCH] net: eth-uclass: Change uclass driver name to ethernet David Wu
2021-01-07 12:36 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox