From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] image: usage of value ~0UL for intrd_high
Date: Sat, 9 Jan 2021 14:40:04 -0500 [thread overview]
Message-ID: <20210109194004.GK2292@bill-the-cat> (raw)
In-Reply-To: <fd5c0e71-6ba7-3dad-0270-f579f49fd89d@gmx.de>
On Sat, Jan 09, 2021 at 08:33:40PM +0100, Heinrich Schuchardt wrote:
> On 1/9/21 7:58 PM, Tom Rini wrote:
> > On Sat, Jan 09, 2021 at 08:47:07PM +0200, Andy Shevchenko wrote:
> > > On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> > > >
> > > > The comment for initrd_high in the coding and in README were contradicting
> > > > and neither fully described what the coding does.
> > > >
> > > > Clarify the usage of the special value ~0UL for the environment variable
> > > > initrd_high.
> > >
> > > All those F:s are hard to read in the comments and documentation and
> > > typo prone. I would prefer to rephrase like "all 1:s value in 32- or
> > > 64-bit format" or alike.
> >
> > If we're going to improve this we should also note it's discouraged
> > unless you know for certain there will be no overlap and it's strongly
> > discouraged in default environments.
>
> What exactly is discouraged?
>
> * setting initrd_high to a value != ~0? Here I would agree.
> * setting intird_high to ~0? Why should we copy initrd to a
> different place? Is it for some outdated Linux release?
We should always default to allowing the initrd to be relocated because
we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values means we
don't have a problem here.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210109/4e501f74/attachment.sig>
next prev parent reply other threads:[~2021-01-09 19:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 18:06 [PATCH 1/1] image: usage of value ~0UL for intrd_high Heinrich Schuchardt
2021-01-09 18:47 ` Andy Shevchenko
2021-01-09 18:58 ` Tom Rini
2021-01-09 19:33 ` Heinrich Schuchardt
2021-01-09 19:40 ` Tom Rini [this message]
2021-01-09 19:59 ` Heinrich Schuchardt
2021-01-09 21:23 ` Tom Rini
2021-01-09 23:23 ` Heinrich Schuchardt
2021-01-10 12:07 ` Adam Ford
2021-01-10 15:36 ` Andy Shevchenko
2021-01-10 12:05 ` Heinrich Schuchardt
2021-01-10 13:43 ` Tom Rini
2021-01-10 16:20 ` Heinrich Schuchardt
2021-01-15 18:43 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109194004.GK2292@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox