public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] cmd: disk: Remove fit_print_contents API
@ 2021-01-08 17:55 Ravik Hasija
  2021-01-13 16:10 ` Simon Glass
  2021-01-18 13:03 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Ravik Hasija @ 2021-01-08 17:55 UTC (permalink / raw)
  To: u-boot

fit_print_contents prints similar fit information as printed in bootm stages.
Removing this API reduces redundancy & provides improvement in boottime.

Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
---

 cmd/disk.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cmd/disk.c b/cmd/disk.c
index 8060e753eb..0bc3808dfe 100644
--- a/cmd/disk.c
+++ b/cmd/disk.c
@@ -120,7 +120,6 @@ int common_diskboot(struct cmd_tbl *cmdtp, const char *intf, int argc,
 			return 1;
 		}
 		bootstage_mark(BOOTSTAGE_ID_IDE_FIT_READ_OK);
-		fit_print_contents(fit_hdr);
 	}
 #endif
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] cmd: disk: Remove fit_print_contents API
  2021-01-08 17:55 [PATCH] cmd: disk: Remove fit_print_contents API Ravik Hasija
@ 2021-01-13 16:10 ` Simon Glass
  2021-01-18 13:03 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-01-13 16:10 UTC (permalink / raw)
  To: u-boot

On Fri, 8 Jan 2021 at 10:56, Ravik Hasija <rahasij@linux.microsoft.com> wrote:
>
> fit_print_contents prints similar fit information as printed in bootm stages.
> Removing this API reduces redundancy & provides improvement in boottime.
>
> Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
> ---
>
>  cmd/disk.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] cmd: disk: Remove fit_print_contents API
  2021-01-08 17:55 [PATCH] cmd: disk: Remove fit_print_contents API Ravik Hasija
  2021-01-13 16:10 ` Simon Glass
@ 2021-01-18 13:03 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-01-18 13:03 UTC (permalink / raw)
  To: u-boot

On Fri, Jan 08, 2021 at 09:55:58AM -0800, Ravik Hasija wrote:

> fit_print_contents prints similar fit information as printed in bootm stages.
> Removing this API reduces redundancy & provides improvement in boottime.
> 
> Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/1e038467/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-18 13:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-08 17:55 [PATCH] cmd: disk: Remove fit_print_contents API Ravik Hasija
2021-01-13 16:10 ` Simon Glass
2021-01-18 13:03 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox