[PATCH] net: ks8851: Reset internal RXFC count on bad packet

[PATCH] net: ks8851: Reset internal RXFC count on bad packet

[Marek Vasut]

A sporadic condition occurs when the "bad packet" error is triggered
repeatedly, which results in "bad packet" messages scrolling on the
console during transfer. To avoid triggering this, reset the internal
RXFC count on the first occurance of the "bad packet", which forces
the code to re-read the RX packet count from the MAC, and prevents
any additional "bad packet" messages if there are no more packets in
the MAC. Also print better debug information if this condition occurs.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Eugen Hristev <eugen.hristev@microchip.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Tom Rini <trini@konsulko.com>
---
NOTE: This should likely also be applied to 2021.01

 drivers/net/ks8851_mll.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ks8851_mll.c b/drivers/net/ks8851_mll.c
index 58e065cdcc2..48c8d499cf4 100644
--- a/drivers/net/ks8851_mll.c
+++ b/drivers/net/ks8851_mll.c
@@ -251,7 +251,8 @@ static int ks_rcv(struct ks_net *ks, uchar *data)
 	}
 
 	ks_wrreg16(ks, KS_RXQCR, RXQCR_CMD_CNTL | RXQCR_RRXEF);
-	printf(DRIVERNAME ": bad packet\n");
+	printf(DRIVERNAME ": bad packet (sts=0x%04x len=0x%04x)\n", sts, len);
+	ks->rxfc = 0;
 	return 0;
 }
 
-- 
2.29.2

[PATCH] net: ks8851: Reset internal RXFC count on bad packet

[Tom Rini]

On Wed, Jan 06, 2021 at 03:16:01PM +0100, Marek Vasut wrote:

> A sporadic condition occurs when the "bad packet" error is triggered
> repeatedly, which results in "bad packet" messages scrolling on the
> console during transfer. To avoid triggering this, reset the internal
> RXFC count on the first occurance of the "bad packet", which forces
> the code to re-read the RX packet count from the MAC, and prevents
> any additional "bad packet" messages if there are no more packets in
> the MAC. Also print better debug information if this condition occurs.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Eugen Hristev <eugen.hristev@microchip.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210119/8509494a/attachment.sig>