* [RESEND PATCH v1 0/1] mmc: fix response timeout after switch command @ 2021-01-23 12:37 Stefan Bosch 2021-01-23 12:37 ` [RESEND PATCH v1 1/1] " Stefan Bosch 0 siblings, 1 reply; 5+ messages in thread From: Stefan Bosch @ 2021-01-23 12:37 UTC (permalink / raw) To: u-boot Currently I am implementing SPL for frienlyARM's NanoPC-T2 board (SoC S5P4418). Loading of U-Boot from SD-card fails if CONFIG_SPL_MMC_TINY=y. I.e. mmc_set_blocklen() inside mmc_bread() fails (Response Timeout), caused by the previous call of __mmc_switch() in drivers/mmc/mmc.c: Here the 'current state' of the card status keeps 'data' for several 100ms after issuing the switch command. Because of this state the next command issued fails (in this case CMD16 = SET_BLOCKLEN). Patch: Wait for 'current state' = 'tran' in __mmc_switch(). Stefan Bosch (1): mmc: fix response timeout after switch command drivers/mmc/mmc.c | 3 ++- include/mmc.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH v1 1/1] mmc: fix response timeout after switch command 2021-01-23 12:37 [RESEND PATCH v1 0/1] mmc: fix response timeout after switch command Stefan Bosch @ 2021-01-23 12:37 ` Stefan Bosch 2021-01-26 23:38 ` Jaehoon Chung 0 siblings, 1 reply; 5+ messages in thread From: Stefan Bosch @ 2021-01-23 12:37 UTC (permalink / raw) To: u-boot After issuing the switch command: Wait until 'current state' of the card status becomes 'tran'. This prevents from response timeout at the next command because of 'current state' = 'data'. Signed-off-by: Stefan Bosch <stefan_b@posteo.net> --- drivers/mmc/mmc.c | 3 ++- include/mmc.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index a47700e313..8ccd2058a9 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -823,7 +823,8 @@ static int __mmc_switch(struct mmc *mmc, u8 set, u8 index, u8 value, value); return -EIO; } - if (!ret && (status & MMC_STATUS_RDY_FOR_DATA)) + if (!ret && (status & MMC_STATUS_RDY_FOR_DATA) && + (status & MMC_STATUS_CURR_STATE) == MMC_STATE_TRANS) return 0; udelay(100); } while (get_timer(start) < timeout_ms); diff --git a/include/mmc.h b/include/mmc.h index 1d377e0281..18402494c6 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -178,6 +178,7 @@ static inline bool mmc_is_tuning_cmd(uint cmdidx) #define MMC_STATUS_ERROR (1 << 19) #define MMC_STATE_PRG (7 << 9) +#define MMC_STATE_TRANS (4 << 9) #define MMC_VDD_165_195 0x00000080 /* VDD voltage 1.65 - 1.95 */ #define MMC_VDD_20_21 0x00000100 /* VDD voltage 2.0 ~ 2.1 */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH v1 1/1] mmc: fix response timeout after switch command 2021-01-23 12:37 ` [RESEND PATCH v1 1/1] " Stefan Bosch @ 2021-01-26 23:38 ` Jaehoon Chung 2021-01-28 19:23 ` Stefan Bosch 0 siblings, 1 reply; 5+ messages in thread From: Jaehoon Chung @ 2021-01-26 23:38 UTC (permalink / raw) To: u-boot Hi, On 1/23/21 9:37 PM, Stefan Bosch wrote: > After issuing the switch command: Wait until 'current state' of the card > status becomes 'tran'. This prevents from response timeout at the next > command because of 'current state' = 'data'.> > Signed-off-by: Stefan Bosch <stefan_b@posteo.net> > --- > > drivers/mmc/mmc.c | 3 ++- > include/mmc.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index a47700e313..8ccd2058a9 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -823,7 +823,8 @@ static int __mmc_switch(struct mmc *mmc, u8 set, u8 index, u8 value, > value); > return -EIO; > } > - if (!ret && (status & MMC_STATUS_RDY_FOR_DATA)) > + if (!ret && (status & MMC_STATUS_RDY_FOR_DATA) && > + (status & MMC_STATUS_CURR_STATE) == MMC_STATE_TRANS) AFAIK, MMC_STATUS_RDY_FOR_DATA bit means the signaling about "buffer is empty". Even though its bit was set, does it need to check TRANS state? Best Regards, Jaehoon Chung > return 0; > udelay(100); > } while (get_timer(start) < timeout_ms); > diff --git a/include/mmc.h b/include/mmc.h > index 1d377e0281..18402494c6 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -178,6 +178,7 @@ static inline bool mmc_is_tuning_cmd(uint cmdidx) > #define MMC_STATUS_ERROR (1 << 19) > > #define MMC_STATE_PRG (7 << 9) > +#define MMC_STATE_TRANS (4 << 9) > > #define MMC_VDD_165_195 0x00000080 /* VDD voltage 1.65 - 1.95 */ > #define MMC_VDD_20_21 0x00000100 /* VDD voltage 2.0 ~ 2.1 */ > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH v1 1/1] mmc: fix response timeout after switch command 2021-01-26 23:38 ` Jaehoon Chung @ 2021-01-28 19:23 ` Stefan Bosch 2021-01-28 22:00 ` Jaehoon Chung 0 siblings, 1 reply; 5+ messages in thread From: Stefan Bosch @ 2021-01-28 19:23 UTC (permalink / raw) To: u-boot Hi, On 27.01.21 00:38, Jaehoon Chung wrote: > Hi, > > On 1/23/21 9:37 PM, Stefan Bosch wrote: >> After issuing the switch command: Wait until 'current state' of the card >> status becomes 'tran'. This prevents from response timeout at the next >> command because of 'current state' = 'data'.> >> Signed-off-by: Stefan Bosch <stefan_b@posteo.net> >> --- >> >> drivers/mmc/mmc.c | 3 ++- >> include/mmc.h | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c >> index a47700e313..8ccd2058a9 100644 >> --- a/drivers/mmc/mmc.c >> +++ b/drivers/mmc/mmc.c >> @@ -823,7 +823,8 @@ static int __mmc_switch(struct mmc *mmc, u8 set, u8 index, u8 value, >> value); >> return -EIO; >> } >> - if (!ret && (status & MMC_STATUS_RDY_FOR_DATA)) >> + if (!ret && (status & MMC_STATUS_RDY_FOR_DATA) && >> + (status & MMC_STATUS_CURR_STATE) == MMC_STATE_TRANS) > > AFAIK, MMC_STATUS_RDY_FOR_DATA bit means the signaling about "buffer is empty". > Even though its bit was set, does it need to check TRANS state? > > Best Regards, > Jaehoon Chung > After issuing command 'MMC_CMD_SWITCH' = CMD6 the state transits to 'DATA'. But in DATA state it is not possible to issue a (new) CMD except CMD12 (operation complete) and CMD7 (select/deselect card). See appropriate State Diagram, e.g. "Figure 4-3: SD Memory Card State Diagram (data transfer mode)" in "SD Specifications Part 1 - Physical Layer - Simplified Specification - Version 2.00". Status 'Ready For Data' is in my opinion only relevant for CMD12 and CMD7. Regards Stefan Bosch >> return 0; >> udelay(100); >> } while (get_timer(start) < timeout_ms); >> diff --git a/include/mmc.h b/include/mmc.h >> index 1d377e0281..18402494c6 100644 >> --- a/include/mmc.h >> +++ b/include/mmc.h >> @@ -178,6 +178,7 @@ static inline bool mmc_is_tuning_cmd(uint cmdidx) >> #define MMC_STATUS_ERROR (1 << 19) >> >> #define MMC_STATE_PRG (7 << 9) >> +#define MMC_STATE_TRANS (4 << 9) >> >> #define MMC_VDD_165_195 0x00000080 /* VDD voltage 1.65 - 1.95 */ >> #define MMC_VDD_20_21 0x00000100 /* VDD voltage 2.0 ~ 2.1 */ >> > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH v1 1/1] mmc: fix response timeout after switch command 2021-01-28 19:23 ` Stefan Bosch @ 2021-01-28 22:00 ` Jaehoon Chung 0 siblings, 0 replies; 5+ messages in thread From: Jaehoon Chung @ 2021-01-28 22:00 UTC (permalink / raw) To: u-boot Hi Stefan, On 1/29/21 4:23 AM, Stefan Bosch wrote: > Hi, > > On 27.01.21 00:38, Jaehoon Chung wrote: >> Hi, >> >> On 1/23/21 9:37 PM, Stefan Bosch wrote: >>> After issuing the switch command: Wait until 'current state' of the card >>> status becomes 'tran'. This prevents from response timeout at the next >>> command because of 'current state' = 'data'.> >>> Signed-off-by: Stefan Bosch <stefan_b@posteo.net> >>> --- >>> >>> ? drivers/mmc/mmc.c | 3 ++- >>> ? include/mmc.h???? | 1 + >>> ? 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c >>> index a47700e313..8ccd2058a9 100644 >>> --- a/drivers/mmc/mmc.c >>> +++ b/drivers/mmc/mmc.c >>> @@ -823,7 +823,8 @@ static int __mmc_switch(struct mmc *mmc, u8 set, u8 index, u8 value, >>> ?????????????????? value); >>> ????????????? return -EIO; >>> ????????? } >>> -??????? if (!ret && (status & MMC_STATUS_RDY_FOR_DATA)) >>> +??????? if (!ret && (status & MMC_STATUS_RDY_FOR_DATA) && >>> +??????????? (status & MMC_STATUS_CURR_STATE) == MMC_STATE_TRANS) >> >> AFAIK, MMC_STATUS_RDY_FOR_DATA bit means the signaling about "buffer is empty". >> Even though its bit was set, does it need to check TRANS state? >> >> Best Regards, >> Jaehoon Chung >> > > After issuing command 'MMC_CMD_SWITCH' = CMD6 the state transits to 'DATA'. But in DATA state it is not possible to issue a (new) CMD except CMD12 (operation complete) and CMD7 (select/deselect card). See appropriate State Diagram, e.g. "Figure 4-3: SD Memory Card State Diagram (data transfer mode)" in "SD Specifications Part 1 - Physical Layer - Simplified Specification - Version 2.00". Status 'Ready For Data' is in my opinion only relevant for CMD12 and CMD7. Thanks for explanation. I have checked Spec about SD and eMMC. It makes sense. Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > > Regards > Stefan Bosch > >>> ????????????? return 0; >>> ????????? udelay(100); >>> ????? } while (get_timer(start) < timeout_ms); >>> diff --git a/include/mmc.h b/include/mmc.h >>> index 1d377e0281..18402494c6 100644 >>> --- a/include/mmc.h >>> +++ b/include/mmc.h >>> @@ -178,6 +178,7 @@ static inline bool mmc_is_tuning_cmd(uint cmdidx) >>> ? #define MMC_STATUS_ERROR??? (1 << 19) >>> ? ? #define MMC_STATE_PRG??????? (7 << 9) >>> +#define MMC_STATE_TRANS??????? (4 << 9) >>> ? ? #define MMC_VDD_165_195??????? 0x00000080??? /* VDD voltage 1.65 - 1.95 */ >>> ? #define MMC_VDD_20_21??????? 0x00000100??? /* VDD voltage 2.0 ~ 2.1 */ >>> >> > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-28 22:00 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-01-23 12:37 [RESEND PATCH v1 0/1] mmc: fix response timeout after switch command Stefan Bosch 2021-01-23 12:37 ` [RESEND PATCH v1 1/1] " Stefan Bosch 2021-01-26 23:38 ` Jaehoon Chung 2021-01-28 19:23 ` Stefan Bosch 2021-01-28 22:00 ` Jaehoon Chung
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox