* [PATCH] w1: mxc: fix build
@ 2021-01-13 10:21 Martin Fuzzey
2021-01-14 15:42 ` Simon Glass
2021-01-23 15:50 ` sbabic at denx.de
0 siblings, 2 replies; 3+ messages in thread
From: Martin Fuzzey @ 2021-01-13 10:21 UTC (permalink / raw)
To: u-boot
Now that header files no longer include common.h it must be included
first.
Otherwise the build fails with errors like
include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
u32 imx_get_uartclk(void);
Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files")
Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
---
drivers/w1/mxc_w1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/mxc_w1.c b/drivers/w1/mxc_w1.c
index 8e6372f..3aeaaf5 100644
--- a/drivers/w1/mxc_w1.c
+++ b/drivers/w1/mxc_w1.c
@@ -17,8 +17,8 @@
* Martin Fuzzey <martin.fuzzey@flowbird.group>
*/
-#include <asm/arch/clock.h>
#include <common.h>
+#include <asm/arch/clock.h>
#include <dm.h>
#include <dm/device_compat.h>
#include <linux/bitops.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] w1: mxc: fix build
2021-01-13 10:21 [PATCH] w1: mxc: fix build Martin Fuzzey
@ 2021-01-14 15:42 ` Simon Glass
2021-01-23 15:50 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-01-14 15:42 UTC (permalink / raw)
To: u-boot
On Wed, 13 Jan 2021 at 03:21, Martin Fuzzey
<martin.fuzzey@flowbird.group> wrote:
>
> Now that header files no longer include common.h it must be included
> first.
>
> Otherwise the build fails with errors like
> include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
> u32 imx_get_uartclk(void);
>
> Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files")
>
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
> ---
> drivers/w1/mxc_w1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] w1: mxc: fix build
2021-01-13 10:21 [PATCH] w1: mxc: fix build Martin Fuzzey
2021-01-14 15:42 ` Simon Glass
@ 2021-01-23 15:50 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: sbabic at denx.de @ 2021-01-23 15:50 UTC (permalink / raw)
To: u-boot
> Now that header files no longer include common.h it must be included
> first.
> Otherwise the build fails with errors like
> include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
> u32 imx_get_uartclk(void);
> Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files")
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-23 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-13 10:21 [PATCH] w1: mxc: fix build Martin Fuzzey
2021-01-14 15:42 ` Simon Glass
2021-01-23 15:50 ` sbabic at denx.de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox