[PATCH] mx6ul(l)evk: Enable DM_ETH_PHY

[PATCH] mx6ul(l)evk: Enable DM_ETH_PHY

[Sean Anderson]

This fixes eth0 not initializing properly. Both eth0 and eth1 use the
MDIO interface on eth1 to access their PHYs. However, without
DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its
phy. Before this patch, a boot log might contain lines like

Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Could not get PHY for FEC0: addr 2

After this patch they now look like

Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Get shared mii bus on ethernet at 2188000

Warning: ethernet at 2188000 using MAC address from ROM
, eth0: ethernet at 2188000

As an alternative to DM_ETH_PHY, FEC_MXC_SHARE_MDIO could also have been
used to achieve the same effect.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

 configs/mx6ul_14x14_evk_defconfig         | 1 +
 configs/mx6ul_9x9_evk_defconfig           | 1 +
 configs/mx6ull_14x14_evk_defconfig        | 1 +
 configs/mx6ull_14x14_evk_plugin_defconfig | 1 +
 4 files changed, 4 insertions(+)

diff --git a/configs/mx6ul_14x14_evk_defconfig b/configs/mx6ul_14x14_evk_defconfig
index f0a155aff3..5c3440f930 100644
--- a/configs/mx6ul_14x14_evk_defconfig
+++ b/configs/mx6ul_14x14_evk_defconfig
@@ -68,6 +68,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
diff --git a/configs/mx6ul_9x9_evk_defconfig b/configs/mx6ul_9x9_evk_defconfig
index 40bb371a69..86027d2d49 100644
--- a/configs/mx6ul_9x9_evk_defconfig
+++ b/configs/mx6ul_9x9_evk_defconfig
@@ -61,6 +61,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
diff --git a/configs/mx6ull_14x14_evk_defconfig b/configs/mx6ull_14x14_evk_defconfig
index 4fdbb915d4..fd33e0a4ef 100644
--- a/configs/mx6ull_14x14_evk_defconfig
+++ b/configs/mx6ull_14x14_evk_defconfig
@@ -47,6 +47,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
diff --git a/configs/mx6ull_14x14_evk_plugin_defconfig b/configs/mx6ull_14x14_evk_plugin_defconfig
index f8f863411e..f3f3fac9c1 100644
--- a/configs/mx6ull_14x14_evk_plugin_defconfig
+++ b/configs/mx6ull_14x14_evk_plugin_defconfig
@@ -48,6 +48,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
-- 
2.25.1

[PATCH] mx6ul(l)evk: Enable DM_ETH_PHY

[Fabio Estevam]

Hi Sean,

On Mon, Dec 28, 2020 at 4:58 PM Sean Anderson <sean.anderson@seco.com> wrote:
>
> This fixes eth0 not initializing properly. Both eth0 and eth1 use the
> MDIO interface on eth1 to access their PHYs. However, without
> DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its
> phy. Before this patch, a boot log might contain lines like
>
> Net:
> Warning: ethernet at 20b4000 using MAC address from ROM
> eth1: ethernet at 20b4000 [PRIME]Could not get PHY for FEC0: addr 2
>
> After this patch they now look like
>
> Net:
> Warning: ethernet at 20b4000 using MAC address from ROM
> eth1: ethernet at 20b4000 [PRIME]Get shared mii bus on ethernet at 2188000
>
> Warning: ethernet at 2188000 using MAC address from ROM
> , eth0: ethernet at 2188000
>
> As an alternative to DM_ETH_PHY, FEC_MXC_SHARE_MDIO could also have been
> used to achieve the same effect.
>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

Thanks for the fix:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

[PATCH] mx6ul(l)evk: Enable DM_ETH_PHY

[sbabic at denx.de]

> This fixes eth0 not initializing properly. Both eth0 and eth1 use the
> MDIO interface on eth1 to access their PHYs. However, without
> DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its
> phy. Before this patch, a boot log might contain lines like
> Net:
> Warning: ethernet at 20b4000 using MAC address from ROM
> eth1: ethernet at 20b4000 [PRIME]Could not get PHY for FEC0: addr 2
> After this patch they now look like
> Net:
> Warning: ethernet at 20b4000 using MAC address from ROM
> eth1: ethernet at 20b4000 [PRIME]Get shared mii bus on ethernet at 2188000
> Warning: ethernet at 2188000 using MAC address from ROM
> , eth0: ethernet at 2188000
> As an alternative to DM_ETH_PHY, FEC_MXC_SHARE_MDIO could also have been
> used to achieve the same effect.
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================