U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Binacchi <dariobin@libero.it>
To: u-boot@lists.denx.de
Subject: [PATCH v2 06/12] pinctrl: single: check "register-width" DT property
Date: Thu, 28 Jan 2021 23:24:55 +0100	[thread overview]
Message-ID: <20210128222501.31943-7-dariobin@libero.it> (raw)
In-Reply-To: <20210128222501.31943-1-dariobin@libero.it>

In more recent versions of the Linux kernel the driver's probe function
returns an error if the "pinctrl-single,register-width" DT property is
missing. The lack of this information, in fact, does not allow to know
whether to access the registers of the controller at 8, 16, ... bits.

Signed-off-by: Dario Binacchi <dariobin@libero.it>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v2:
- Updated commit message.
- Added Simon Glass review tag.

 drivers/pinctrl/pinctrl-single.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index d5656de8e8..5ade108875 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -22,7 +22,7 @@ struct single_pdata {
 	fdt_addr_t base;
 	int offset;
 	u32 mask;
-	int width;
+	u32 width;
 	bool bits_per_mux;
 };
 
@@ -184,9 +184,13 @@ static int single_of_to_plat(struct udevice *dev)
 	fdt_addr_t addr;
 	fdt_size_t size;
 	struct single_pdata *pdata = dev_get_plat(dev);
+	int ret;
 
-	pdata->width =
-		dev_read_u32_default(dev, "pinctrl-single,register-width", 0);
+	ret = dev_read_u32(dev, "pinctrl-single,register-width", &pdata->width);
+	if (ret) {
+		dev_err(dev, "missing register width\n");
+		return ret;
+	}
 
 	addr = dev_read_addr_size(dev, "reg", &size);
 	if (addr == FDT_ADDR_T_NONE) {
-- 
2.17.1

  parent reply	other threads:[~2021-01-28 22:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 22:24 [PATCH v2 00/12] Add support for pinmux status command on beaglebone Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 01/12] pinctrl: single: fix format of structure documentation Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 02/12] pinctrl: single: fix the loop counter variable type Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 03/12] pinctrl: single: fix offset management Dario Binacchi
2021-01-29 16:50   ` Pratyush Yadav
2021-01-28 22:24 ` [PATCH v2 04/12] pinctrl: single: fix debug messages formatting Dario Binacchi
2021-01-29 16:53   ` Pratyush Yadav
2021-01-28 22:24 ` [PATCH v2 05/12] pinctrl: single: get register area size by device API Dario Binacchi
2021-01-29 17:47   ` Pratyush Yadav
2021-01-28 22:24 ` Dario Binacchi [this message]
2021-01-28 22:24 ` [PATCH v2 07/12] pinctrl: single: change function mask default value Dario Binacchi
2021-02-01 20:44   ` Simon Glass
2021-01-28 22:24 ` [PATCH v2 08/12] pinctrl: single: add register access functions Dario Binacchi
2021-02-01 20:44   ` Simon Glass
2021-01-28 22:24 ` [PATCH v2 09/12] pinctrl: single: add get_pins_count operation Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 10/12] pinctrl: single: add get_pin_name operation Dario Binacchi
2021-01-28 22:25 ` [PATCH v2 11/12] pinctrl: single: add get_pin_muxing operation Dario Binacchi
2021-02-01 20:44   ` Simon Glass
2021-01-28 22:25 ` [PATCH v2 12/12] test: pinmux: add test for 'pinctrl-single' driver Dario Binacchi
2021-02-04 18:02 ` [PATCH v2 00/12] Add support for pinmux status command on beaglebone Lokesh Vutla
2021-02-05 10:54   ` Dario Binacchi
2021-02-05 14:17     ` Lokesh Vutla
2021-02-05 18:37       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128222501.31943-7-dariobin@libero.it \
    --to=dariobin@libero.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox