From: Pratyush Yadav <p.yadav@ti.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 04/12] pinctrl: single: fix debug messages formatting
Date: Fri, 29 Jan 2021 22:23:49 +0530 [thread overview]
Message-ID: <20210129165347.h6kitrjvcv42xcja@ti.com> (raw)
In-Reply-To: <20210128222501.31943-5-dariobin@libero.it>
On 28/01/21 11:24PM, Dario Binacchi wrote:
> The dev_dbg(dev, " reg/val 0x%pa/0x%08x\n", ®, val); prints the 'reg'
> address preceded by the prefix 0x0x instead of 0x. This because the
> printf '%pa' format specifier already appends the prefix '0x' to the
s/appends/prepends/
Other than that,
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> address displayed.
>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
>
> ---
>
> Changes in v2:
> - Updated commit message
> - Split in 2 commits
>
> drivers/pinctrl/pinctrl-single.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 935b5e920d..cec00e289c 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -101,7 +101,7 @@ static int single_configure_pins(struct udevice *dev,
> pdata->width);
> continue;
> }
> - dev_dbg(dev, " reg/val 0x%pa/0x%08x\n", ®, val);
> + dev_dbg(dev, " reg/val %pa/0x%08x\n", ®, val);
> }
> return 0;
> }
> @@ -140,7 +140,7 @@ static int single_configure_bits(struct udevice *dev,
> pdata->width);
> continue;
> }
> - dev_dbg(dev, " reg/val 0x%pa/0x%08x\n", ®, val);
> + dev_dbg(dev, " reg/val %pa/0x%08x\n", ®, val);
> }
> return 0;
> }
> --
> 2.17.1
>
--
Regards,
Pratyush Yadav
Texas Instruments India
next prev parent reply other threads:[~2021-01-29 16:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 22:24 [PATCH v2 00/12] Add support for pinmux status command on beaglebone Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 01/12] pinctrl: single: fix format of structure documentation Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 02/12] pinctrl: single: fix the loop counter variable type Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 03/12] pinctrl: single: fix offset management Dario Binacchi
2021-01-29 16:50 ` Pratyush Yadav
2021-01-28 22:24 ` [PATCH v2 04/12] pinctrl: single: fix debug messages formatting Dario Binacchi
2021-01-29 16:53 ` Pratyush Yadav [this message]
2021-01-28 22:24 ` [PATCH v2 05/12] pinctrl: single: get register area size by device API Dario Binacchi
2021-01-29 17:47 ` Pratyush Yadav
2021-01-28 22:24 ` [PATCH v2 06/12] pinctrl: single: check "register-width" DT property Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 07/12] pinctrl: single: change function mask default value Dario Binacchi
2021-02-01 20:44 ` Simon Glass
2021-01-28 22:24 ` [PATCH v2 08/12] pinctrl: single: add register access functions Dario Binacchi
2021-02-01 20:44 ` Simon Glass
2021-01-28 22:24 ` [PATCH v2 09/12] pinctrl: single: add get_pins_count operation Dario Binacchi
2021-01-28 22:24 ` [PATCH v2 10/12] pinctrl: single: add get_pin_name operation Dario Binacchi
2021-01-28 22:25 ` [PATCH v2 11/12] pinctrl: single: add get_pin_muxing operation Dario Binacchi
2021-02-01 20:44 ` Simon Glass
2021-01-28 22:25 ` [PATCH v2 12/12] test: pinmux: add test for 'pinctrl-single' driver Dario Binacchi
2021-02-04 18:02 ` [PATCH v2 00/12] Add support for pinmux status command on beaglebone Lokesh Vutla
2021-02-05 10:54 ` Dario Binacchi
2021-02-05 14:17 ` Lokesh Vutla
2021-02-05 18:37 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129165347.h6kitrjvcv42xcja@ti.com \
--to=p.yadav@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox