From: Marek Behun <marek.behun@nic.cz>
To: u-boot@lists.denx.de
Subject: [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
Date: Wed, 3 Feb 2021 14:41:40 +0100 [thread overview]
Message-ID: <20210203144140.3c76b442@nic.cz> (raw)
In-Reply-To: <062bada8-1acf-2af1-38aa-54b915d72c65@samsung.com>
On Wed, 3 Feb 2021 08:32:45 +0900
Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 2/3/21 2:37 AM, Marek Beh?n wrote:
> > This is needed to parse more capabilities such as `non-removable`.
> >
> > Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
> > a regression on Turris Omnia, because mv_sdhci driver did not fill out
> > host_caps from device-tree.
> >
> > Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
> > Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")
>
> I don't think that this patch is for fixing its commit.
>
> Best Regards,
> Jaehoon Chung
Commit da18c62b6e6a causes the regression. The Fixes tag, as I
understand, should link to commit with which the regression first
occured, so that if someone wanted to backport my patch to previous
version of U-Boot, they would know that they only have to do it if
their repository contains that commit.
Marek
next prev parent reply other threads:[~2021-02-03 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210202173759epcas1p25f47e0c37663fa3db9da5b10c7f589e9@epcas1p2.samsung.com>
2021-02-02 17:37 ` [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse() Marek Behún
2021-02-02 17:52 ` Baruch Siach
2021-02-02 18:02 ` Marek Behún
2021-02-02 23:32 ` Jaehoon Chung
2021-02-03 13:41 ` Marek Behun [this message]
2021-02-03 22:18 ` Jaehoon Chung
2021-02-04 16:38 ` Marek Behún
2021-02-04 22:21 ` Jaehoon Chung
2021-02-08 11:40 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203144140.3c76b442@nic.cz \
--to=marek.behun@nic.cz \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox