* [PATCH] Makefile: Silence the deprecation script
@ 2021-03-31 22:18 Simon Glass
2021-03-31 22:19 ` Simon Glass
2021-04-01 14:36 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Simon Glass @ 2021-03-31 22:18 UTC (permalink / raw)
To: u-boot
This bash code is currently showing up in the build unless 'make -s' is
used. We don't normally show these sorts of things as they are confusing.
Also this code was not shown before the recent refactoring of how these
messages are displayed.
Add an '@' to silence it.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Bin Meng <bmeng.cn@gmail.com>
Fixes: 13732528516 ("Makefile: Add common code to report deprecation")
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index e60717f7a27..84d1112e0a2 100644
--- a/Makefile
+++ b/Makefile
@@ -1027,7 +1027,7 @@ expect = $(foreach cfg,$(1),y)
# Note: Script avoids bash construct, hence the strange double 'if'
# (patches welcome!)
define deprecated
- if [ -n "$(strip $(4))" ]; then if [ "$(got)" != "$(expect)" ]; then \
+ @if [ -n "$(strip $(4))" ]; then if [ "$(got)" != "$(expect)" ]; then \
echo >&2 "===================== WARNING ======================"; \
echo >&2 "This board does not use $(firstword $(1)) (Driver Model"; \
echo >&2 "for $(2)). Please update the board to use"; \
--
2.31.0.291.g576ba9dcdaf-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] Makefile: Silence the deprecation script
2021-03-31 22:18 [PATCH] Makefile: Silence the deprecation script Simon Glass
@ 2021-03-31 22:19 ` Simon Glass
2021-04-01 14:36 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-03-31 22:19 UTC (permalink / raw)
To: u-boot
Suggested-by: Tom Rini <trini@konsulko.com>
On Thu, 1 Apr 2021 at 11:18, Simon Glass <sjg@chromium.org> wrote:
>
> This bash code is currently showing up in the build unless 'make -s' is
> used. We don't normally show these sorts of things as they are confusing.
> Also this code was not shown before the recent refactoring of how these
> messages are displayed.
>
> Add an '@' to silence it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reported-by: Bin Meng <bmeng.cn@gmail.com>
> Fixes: 13732528516 ("Makefile: Add common code to report deprecation")
> ---
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index e60717f7a27..84d1112e0a2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1027,7 +1027,7 @@ expect = $(foreach cfg,$(1),y)
> # Note: Script avoids bash construct, hence the strange double 'if'
> # (patches welcome!)
> define deprecated
> - if [ -n "$(strip $(4))" ]; then if [ "$(got)" != "$(expect)" ]; then \
> + @if [ -n "$(strip $(4))" ]; then if [ "$(got)" != "$(expect)" ]; then \
> echo >&2 "===================== WARNING ======================"; \
> echo >&2 "This board does not use $(firstword $(1)) (Driver Model"; \
> echo >&2 "for $(2)). Please update the board to use"; \
> --
> 2.31.0.291.g576ba9dcdaf-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] Makefile: Silence the deprecation script
2021-03-31 22:18 [PATCH] Makefile: Silence the deprecation script Simon Glass
2021-03-31 22:19 ` Simon Glass
@ 2021-04-01 14:36 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-04-01 14:36 UTC (permalink / raw)
To: u-boot
On Thu, Apr 01, 2021 at 11:18:13AM +1300, Simon Glass wrote:
> This bash code is currently showing up in the build unless 'make -s' is
> used. We don't normally show these sorts of things as they are confusing.
> Also this code was not shown before the recent refactoring of how these
> messages are displayed.
>
> Add an '@' to silence it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reported-by: Bin Meng <bmeng.cn@gmail.com>
> Fixes: 13732528516 ("Makefile: Add common code to report deprecation")
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210401/b4d9626f/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-01 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-31 22:18 [PATCH] Makefile: Silence the deprecation script Simon Glass
2021-03-31 22:19 ` Simon Glass
2021-04-01 14:36 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox