* [PATCH] checkpatch: Ignore ENOSYS warnings
@ 2021-04-12 4:21 Sean Anderson
2021-04-12 18:04 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Sean Anderson @ 2021-04-12 4:21 UTC (permalink / raw)
To: u-boot
There are no system calls in U-Boot, but ENOSYS is still allowed (and
preferred since 42a2668743 ("dm: core: Document the common error codes")).
Silence this warning.
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Seriies-to: sjg
---
.checkpatch.conf | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.checkpatch.conf b/.checkpatch.conf
index ed0c2150ba..9e40ea060b 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -26,6 +26,9 @@
# addresses are __aligned(2)".
--ignore PREFER_ETHER_ADDR_COPY
+# ENOSYS is a conventionally used error, even though U-Boot lacks system calls.
+--ignore ENOSYS
+
# A bit shorter of a description is OK with us.
--min-conf-desc-length=2
--
2.31.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] checkpatch: Ignore ENOSYS warnings
2021-04-12 4:21 [PATCH] checkpatch: Ignore ENOSYS warnings Sean Anderson
@ 2021-04-12 18:04 ` Simon Glass
2021-04-12 23:31 ` Sean Anderson
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2021-04-12 18:04 UTC (permalink / raw)
To: u-boot
Hi Sean,
On Mon, 12 Apr 2021 at 16:22, Sean Anderson <seanga2@gmail.com> wrote:
>
> There are no system calls in U-Boot, but ENOSYS is still allowed (and
> preferred since 42a2668743 ("dm: core: Document the common error codes")).
> Silence this warning.
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> Seriies-to: sjg
This looks OK, except for that tag.
Regards,
Simon
> ---
>
> .checkpatch.conf | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.checkpatch.conf b/.checkpatch.conf
> index ed0c2150ba..9e40ea060b 100644
> --- a/.checkpatch.conf
> +++ b/.checkpatch.conf
> @@ -26,6 +26,9 @@
> # addresses are __aligned(2)".
> --ignore PREFER_ETHER_ADDR_COPY
>
> +# ENOSYS is a conventionally used error, even though U-Boot lacks system calls.
> +--ignore ENOSYS
> +
> # A bit shorter of a description is OK with us.
> --min-conf-desc-length=2
>
> --
> 2.31.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] checkpatch: Ignore ENOSYS warnings
2021-04-12 18:04 ` Simon Glass
@ 2021-04-12 23:31 ` Sean Anderson
2021-04-14 19:37 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Sean Anderson @ 2021-04-12 23:31 UTC (permalink / raw)
To: u-boot
On 4/12/21 2:04 PM, Simon Glass wrote:
> Hi Sean,
>
> On Mon, 12 Apr 2021 at 16:22, Sean Anderson <seanga2@gmail.com> wrote:
>>
>> There are no system calls in U-Boot, but ENOSYS is still allowed (and
>> preferred since 42a2668743 ("dm: core: Document the common error codes")).
>> Silence this warning.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> Seriies-to: sjg
>
> This looks OK, except for that tag.
Should I resend the patch?
--Sean
>
> Regards,
> Simon
>
>
>> ---
>>
>> .checkpatch.conf | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/.checkpatch.conf b/.checkpatch.conf
>> index ed0c2150ba..9e40ea060b 100644
>> --- a/.checkpatch.conf
>> +++ b/.checkpatch.conf
>> @@ -26,6 +26,9 @@
>> # addresses are __aligned(2)".
>> --ignore PREFER_ETHER_ADDR_COPY
>>
>> +# ENOSYS is a conventionally used error, even though U-Boot lacks system calls.
>> +--ignore ENOSYS
>> +
>> # A bit shorter of a description is OK with us.
>> --min-conf-desc-length=2
>>
>> --
>> 2.31.0
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] checkpatch: Ignore ENOSYS warnings
2021-04-12 23:31 ` Sean Anderson
@ 2021-04-14 19:37 ` Simon Glass
0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2021-04-14 19:37 UTC (permalink / raw)
To: u-boot
Hi Sean,
On Tue, 13 Apr 2021 at 00:31, Sean Anderson <seanga2@gmail.com> wrote:
>
> On 4/12/21 2:04 PM, Simon Glass wrote:
> > Hi Sean,
> >
> > On Mon, 12 Apr 2021 at 16:22, Sean Anderson <seanga2@gmail.com> wrote:
> >>
> >> There are no system calls in U-Boot, but ENOSYS is still allowed (and
> >> preferred since 42a2668743 ("dm: core: Document the common error codes")).
> >> Silence this warning.
> >>
> >> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> >> Seriies-to: sjg
> >
> > This looks OK, except for that tag.
>
> Should I resend the patch?
Yes I think that would be easiest.
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-14 19:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-12 4:21 [PATCH] checkpatch: Ignore ENOSYS warnings Sean Anderson
2021-04-12 18:04 ` Simon Glass
2021-04-12 23:31 ` Sean Anderson
2021-04-14 19:37 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox