public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: liu.ming50@gmail.com
To: u-boot@lists.denx.de
Cc: sergio.prado@toradex.com, max.krummenacher@toradex.com,
	Ming Liu <liu.ming50@gmail.com>
Subject: [[PATCH] tools: image-host: fix wrong return value
Date: Mon, 31 May 2021 09:04:51 +0200	[thread overview]
Message-ID: <20210531070451.6561-1-liu.ming50@gmail.com> (raw)

From: Ming Liu <liu.ming50@gmail.com>

The return value '-ENOSPC' of fit_set_timestamp function does not match
the caller fit_image_write_sig's expection which is '-FDT_ERR_NOSPACE'.

Fix it by not calling fit_set_timestamp, but call fdt_setprop instead.

This fixes a following mkimage error:
| Can't write signature for 'signature@1' signature node in
| 'conf@imx6ull-colibri-wifi-eval-v3.dtb' conf node: <unknown error>
| mkimage Can't add hashes to FIT blob: -1

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 tools/image-host.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/image-host.c b/tools/image-host.c
index 270d36fe45..73095461a7 100644
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -132,8 +132,10 @@ static int fit_image_write_sig(void *fit, int noffset, uint8_t *value,
 	if (!ret) {
 		time_t timestamp = imagetool_get_source_date(cmdname,
 							     time(NULL));
+		uint32_t t = cpu_to_uimage(timestamp);
 
-		ret = fit_set_timestamp(fit, noffset, timestamp);
+		ret = fdt_setprop(fit, noffset, FIT_TIMESTAMP_PROP, &t,
+			sizeof(uint32_t));
 	}
 	if (region_prop && !ret) {
 		uint32_t strdata[2];
-- 
2.29.0


             reply	other threads:[~2021-05-31  7:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31  7:04 liu.ming50 [this message]
2021-07-13 15:35 ` [[PATCH] tools: image-host: fix wrong return value Igor Opaniuk
2021-07-15  1:27 ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2021-05-30  8:56 liu.ming50

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210531070451.6561-1-liu.ming50@gmail.com \
    --to=liu.ming50@gmail.com \
    --cc=max.krummenacher@toradex.com \
    --cc=sergio.prado@toradex.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox