From: Tom Rini <trini@konsulko.com>
To: liu.ming50@gmail.com
Cc: u-boot@lists.denx.de, sergio.prado@toradex.com,
max.krummenacher@toradex.com
Subject: Re: [[PATCH] tools: image-host: fix wrong return value
Date: Wed, 14 Jul 2021 21:27:44 -0400 [thread overview]
Message-ID: <20210715012744.GM9516@bill-the-cat> (raw)
In-Reply-To: <20210531070451.6561-1-liu.ming50@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On Mon, May 31, 2021 at 09:04:51AM +0200, liu.ming50@gmail.com wrote:
> From: Ming Liu <liu.ming50@gmail.com>
>
> The return value '-ENOSPC' of fit_set_timestamp function does not match
> the caller fit_image_write_sig's expection which is '-FDT_ERR_NOSPACE'.
>
> Fix it by not calling fit_set_timestamp, but call fdt_setprop instead.
>
> This fixes a following mkimage error:
> | Can't write signature for 'signature@1' signature node in
> | 'conf@imx6ull-colibri-wifi-eval-v3.dtb' conf node: <unknown error>
> | mkimage Can't add hashes to FIT blob: -1
>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> Tested-by: Igor Opaniuk <igor.opaniuk@foundries.io>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-07-15 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:04 [[PATCH] tools: image-host: fix wrong return value liu.ming50
2021-07-13 15:35 ` Igor Opaniuk
2021-07-15 1:27 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-30 8:56 liu.ming50
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715012744.GM9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=liu.ming50@gmail.com \
--cc=max.krummenacher@toradex.com \
--cc=sergio.prado@toradex.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox