From: Tom Rini <trini@konsulko.com>
To: Da Xue <da@libre.computer>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] autoboot: fix typos of CONFIG_AUTOBOOT_USE_MENUKEY
Date: Fri, 2 Jul 2021 19:10:40 -0400 [thread overview]
Message-ID: <20210702231040.GK9516@bill-the-cat> (raw)
In-Reply-To: <CACdvmAhdbctzkSY+VXuwNYavMRAbjudaa3jcak4Q4Z8eH8bHvw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Fri, Jul 02, 2021 at 12:22:01PM -0400, Da Xue wrote:
> Hi Tom,
>
> There is a distinction between the two flags CONFIG_AUTOBOOT_USE_MENUKEY
> AND CONFIG_AUTOBOOT_MENUKEY.
>
> config AUTOBOOT_USE_MENUKEY
> bool "Allow a specify key to run a menu from the environment"
> depends on !AUTOBOOT_KEYED
> help
> If a specific key is pressed to stop autoboot, then the commands in
> the environment variable 'menucmd' are executed before boot starts.
>
> config AUTOBOOT_MENUKEY
> int "ASCII value of boot key to show a menu"
> default 0
> depends on AUTOBOOT_USE_MENUKEY
> help
> If this key is pressed to stop autoboot, then the commands in the
> environment variable 'menucmd' will be executed before boot starts.
> For example, 33 means "!" in ASCII, so pressing ! at boot would take
> this action.
>
> The modified patch that was merged causes Kconfig to remove both flags. I
> will send another patch.
Ah, thanks for catching that!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-07-02 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 2:39 [PATCH] autoboot: fix typos of CONFIG_AUTOBOOT_USE_MENUKEY Da Xue
2021-06-24 13:16 ` Tom Rini
2021-07-02 16:22 ` Da Xue
2021-07-02 23:10 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702231040.GK9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=da@libre.computer \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox