From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Michael Walle <michael@walle.cc>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Tom Rini <trini@konsulko.com>,
Peter Griffin <peter.griffin@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node
Date: Wed, 15 Sep 2021 10:36:44 +0000 [thread overview]
Message-ID: <20210915103643.bffuyiv2bv3utj3l@skbuf> (raw)
In-Reply-To: <821a30e635e5c2b78f283342cbb9b883@walle.cc>
On Wed, Sep 15, 2021 at 10:09:45AM +0200, Michael Walle wrote:
> Am 2021-09-15 02:17, schrieb Vladimir Oltean:
> > On Thu, Sep 02, 2021 at 06:45:56PM +0200, Michael Walle wrote:
> > > The linux device tree hasn't set this property. To be similarly we
> > > remove
> >
> > s/similarly/similar/
> >
> > > it from the u-boot device tree, too. The second controller of the
> > > LS1028A has indeed no card detect pin.
> >
> > Because it is an eMMC controller.
> >
> > > The present state register of the
> > > second controller will always report the card as present. Thus, there
> > > should be no functional change otherwise than one more register access
> > > to read the present state.
> >
> > Tested?
>
> Yes, I've tested the eMMC (and actually using it this way). I also
> manually read out the register value and made sure the card detect
> bit is set.
>
> > > The property should still be introduced in
> > > the linux device tree.
> >
> > How do you feel about dropping this patch?
>
> If I drop this patch, I'll either have to (1) keep this property
> the device tree sync patch too or (2) it will be removed without a
> comment in that patch.
>
> I presume you prefer (1), but as I said, I'd keep the device trees
> between linux and u-boot the same and keep it simple by just copying
> the files. So yes, I'd like to keep this patch as the point of this
> patch is to give an explanation why this property is removed (until
> it might or might not be introduced in the kernel device tree; in
> fact I thought I had send a patch to the LKML but I must have
> forgotten it).
>
> I was thinking of putting it into the -u-boot.dtsi, but as there
> is no breakage, I didn't.
Ok, but we should still put "non-removable" in the Linux dtsi soon then.
next prev parent reply other threads:[~2021-09-15 10:36 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 16:45 [PATCH v3 00/29] arm: dts: ls1028a: sync device tree with linux Michael Walle
2021-09-02 16:45 ` [PATCH v3 01/29] armv8: ls1028a: add IOMMU stream ID to vivante node Michael Walle
2021-09-16 9:53 ` Vladimir Oltean
2021-09-16 10:15 ` Michael Walle
2021-09-02 16:45 ` [PATCH v3 02/29] arm: dts: ls1028a: remove /memory node Michael Walle
2021-09-02 16:45 ` [PATCH v3 03/29] arm: dts: ls1028a-{rdb, qds}: remove dm-pre-reloc property Michael Walle
2021-09-14 23:43 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 04/29] arm: dts: ls1028a: add an empty /soc Michael Walle
2021-09-14 23:43 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 05/29] arm: dts: ls1028a: move the clockgen node into /soc Michael Walle
2021-09-14 23:44 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 06/29] arm: dts: ls1028a: move I2C controller nodes " Michael Walle
2021-09-14 23:47 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 07/29] arm: dts: ls1028a: move the FlexSPI controller node Michael Walle
2021-09-14 23:47 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 08/29] arm: dts: ls1028a: move the SPI and eSDHC controller nodes into /soc Michael Walle
2021-09-14 23:48 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 09/29] arm: dts: ls1028a: move the UART " Michael Walle
2021-09-14 23:49 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 10/29] arm: dts: ls1028a: move the low-power UART " Michael Walle
2021-09-14 23:50 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 11/29] arm: dts: ls1028a: move the GPIO controller " Michael Walle
2021-09-14 23:51 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 12/29] arm: dts: ls1028a: move SATA and USB " Michael Walle
2021-09-14 23:52 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 13/29] arm: dts: ls1028a: move the PCIe " Michael Walle
2021-09-14 23:53 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 14/29] arm: dts: ls1028a: move the watchdog node " Michael Walle
2021-09-14 23:54 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 15/29] arm: dts: ls1028a: move the iRC node and its devices " Michael Walle
2021-09-14 23:56 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 16/29] arm: dts: ls1028a: update the labels Michael Walle
2021-09-15 0:02 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 17/29] watchdog: sp805_wdt: use correct compatible string Michael Walle
2021-09-02 16:45 ` [PATCH v3 18/29] spi: fsl_dspi: add new compatible fsl, ls1021a-v1.0-dspi Michael Walle
2021-09-02 16:45 ` [PATCH v3 19/29] spi: fsl_dspi: rename num-cs to spi-num-chipselects Michael Walle
2021-09-15 0:05 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 20/29] serial: lpuart: add new compatible fsl, ls1028a-lpuart Michael Walle
2021-09-02 16:45 ` [PATCH v3 21/29] scsi: ceva: rename the resource name to match the linux kernel one Michael Walle
2021-09-15 0:10 ` Vladimir Oltean
2021-09-15 7:26 ` Michael Walle
2021-09-02 16:45 ` [PATCH v3 22/29] usb: xhci: fsl: add new compatible fsl,ls1028a-dwc3 Michael Walle
2021-09-03 23:51 ` [PATCH v3 22/29] usb: xhci: fsl: add new compatible fsl, ls1028a-dwc3 Bin Meng
2021-09-02 16:45 ` [PATCH v3 23/29] pci: layerscape: add official ls1028a binding support Michael Walle
2021-09-02 16:45 ` [PATCH v3 24/29] arm: dts: ls1028a: remove num-lanes in the PCIe controller nodes Michael Walle
2021-09-15 0:12 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 25/29] arm: dts: ls1028a: move the PCI I/O window to match Michael Walle
2021-09-15 0:13 ` Vladimir Oltean
2021-09-16 4:03 ` Z.Q. Hou
2021-09-02 16:45 ` [PATCH v3 26/29] arm: dts: ls1028a: disable the PCIe controller by default Michael Walle
2021-09-15 0:14 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node Michael Walle
2021-09-15 0:17 ` Vladimir Oltean
2021-09-15 8:09 ` Michael Walle
2021-09-15 10:36 ` Vladimir Oltean [this message]
2021-10-05 7:57 ` Michael Walle
2021-09-02 16:45 ` [PATCH v3 28/29] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Michael Walle
2021-09-15 0:24 ` Vladimir Oltean
2021-09-02 16:45 ` [PATCH v3 29/29] arm: dts: sl28: sync dtbs Michael Walle
2021-09-15 0:27 ` Vladimir Oltean
2021-10-05 0:39 ` [PATCH v3 00/29] arm: dts: ls1028a: sync device tree with linux Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915103643.bffuyiv2bv3utj3l@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=jagan@amarulasolutions.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michael@walle.cc \
--cc=peter.griffin@linaro.org \
--cc=priyanka.jain@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox