public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
	Joe Hershberger <joe.hershberger@ni.com>
Subject: Re: [PATCH 1/3] phy: sun4i-usb: Remove a couple of debug messages
Date: Mon, 25 Oct 2021 15:07:05 +0100	[thread overview]
Message-ID: <20211025150705.24bca1de@slackpad.fritz.box> (raw)
In-Reply-To: <20210912142243.9912-2-samuel@sholland.org>

On Sun, 12 Sep 2021 09:22:40 -0500
Samuel Holland <samuel@sholland.org> wrote:

> Both of these messages log the GPIO number of the ID detection GPIO,
> which is not terribly useful, especially in the VBUS detection function.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
> 
>  drivers/phy/allwinner/phy-sun4i-usb.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
> index 82713b83815..5302b809ee6 100644
> --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> @@ -393,8 +393,6 @@ int sun4i_usb_phy_vbus_detect(struct phy *phy)
>  	struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id];
>  	int err, retries = 3;
>  
> -	debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det);
> -
>  	if (usb_phy->gpio_vbus_det < 0)
>  		return usb_phy->gpio_vbus_det;
>  
> @@ -417,8 +415,6 @@ int sun4i_usb_phy_id_detect(struct phy *phy)
>  	struct sun4i_usb_phy_data *data = dev_get_priv(phy->dev);
>  	struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id];
>  
> -	debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det);
> -
>  	if (usb_phy->gpio_id_det < 0)
>  		return usb_phy->gpio_id_det;
>  


  reply	other threads:[~2021-10-25 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 14:22 [PATCH 0/3] phy: sun4i-usb: Support VBUS detection via power supply Samuel Holland
2021-09-12 14:22 ` [PATCH 1/3] phy: sun4i-usb: Remove a couple of debug messages Samuel Holland
2021-10-25 14:07   ` Andre Przywara [this message]
2021-09-12 14:22 ` [PATCH 2/3] phy: sun4i-usb: Refactor VBUS detection to match Linux Samuel Holland
2021-10-25 14:08   ` Andre Przywara
2021-09-12 14:22 ` [PATCH 3/3] phy: sun4i-usb: Support VBUS detection via power supply Samuel Holland
2021-10-25 14:08   ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211025150705.24bca1de@slackpad.fritz.box \
    --to=andre.przywara@arm.com \
    --cc=jagan@amarulasolutions.com \
    --cc=joe.hershberger@ni.com \
    --cc=samuel@sholland.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox