From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, Fabio Estevam <festevam@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Peng Fan <peng.fan@nxp.com>, Stefano Babic <sbabic@denx.de>
Subject: Re: [PATCH 1/2] env: mmc: Add missing eMMC bootpart restoration to env erase
Date: Tue, 26 Oct 2021 09:34:35 -0400 [thread overview]
Message-ID: <20211026133435.GF8284@bill-the-cat> (raw)
In-Reply-To: <20211006162954.63596-1-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Wed, Oct 06, 2021 at 06:29:53PM +0200, Marek Vasut wrote:
> If the environment is stored in eMMC hardware boot partition, the environment
> driver first stores the currently selected eMMC boot partition, then does the
> requested operation, and then restores the original boot partition settings.
> In case the environment operation fails, the boot partition settings are also
> restored.
>
> The 'env erase' implementation in the MMC environment driver lacks the path
> which restores the boot partition. This could lead to various failure modes,
> like the system boots the wrong copy of bootloader etc. Fix this by filling
> in the missing restoration path.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-10-26 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 16:29 [PATCH 1/2] env: mmc: Add missing eMMC bootpart restoration to env erase Marek Vasut
2021-10-06 16:29 ` [PATCH 2/2] env: mmc: Add support for redundant env in both eMMC boot partitions Marek Vasut
2021-10-15 16:42 ` Tom Rini
2021-10-26 13:34 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026133435.GF8284@bill-the-cat \
--to=trini@konsulko.com \
--cc=festevam@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox